Summary:ASTERISK-12674: [patch] Rewrite the config stuff to seperate lines and devices
Reporter:Damien Wedhorn (wedhorn)Labels:
Date Opened:2008-09-02 05:53:13Date Closed:2008-10-17 00:50:06
Versions:Frequency of
Environment:Attachments:( 0) config-restruct-v1.diff
( 1) config-restruct-v2.diff
( 2) config-restruct-v3.diff
( 3) config-restruct-v4.diff
( 4) skinny.conf
Description:Allows for the individual building of lines and devices. Devices still point to lines, but a line will only point to a device when the device actually registers. This should assist in realtime development.

Also significant changes to skinny.conf and handling of the config file.

Needs work (and input).


New skinny.conf is:
general opts

global device opts



global line opts

Comments:By: Damien Wedhorn (wedhorn) 2008-09-19 03:49:28

New patch (v2). Cleaned up. Applies to rev 143082.

Probably needs some work on the config options such as which should be lines, devices or both, but really need some discussion about this and the issue has generally always existed in skinny.

By: Michiel van Baak (mvanbaak) 2008-09-20 05:01:18

Can you upload a sample skinny.conf ?

By: Michiel van Baak (mvanbaak) 2008-09-20 09:32:06

New patch (v3)

- remove crash with remove_stale_contexts
- fix problem with speeddials because if they are a hint they are added to the device using lineInstance counter. Because the lines were added without incrementing this variable, it would only add the speeddials that had instance higher then the number of lines attached to the device.

Seems to work ok with my 7960

By: Damien Wedhorn (wedhorn) 2008-09-23 15:42:00

And another (v4).

- includes a restructure of skinny.conf.sample
- hack to stop a line being assigned to more than one device (in config_parse)

works on my 30VIPs including handling overlapping lines.

By: Michiel van Baak (mvanbaak) 2008-09-25 20:24:42

I'll test it somewhere during the next couple of days with a 7960

By: Michiel van Baak (mvanbaak) 2008-09-26 21:49:52

On line 6326 replace the &CDEV->name with CDEV->name (without the &) and it will actually compile under devmode.

Rest of the patch looks nice.

By: Michiel van Baak (mvanbaak) 2008-10-12 05:18:08

Can I commit this? It's been working fine on my box for a couple of weeks now.
Any objections ?

By: Damien Wedhorn (wedhorn) 2008-10-12 15:00:56

Fine by me, assuming you've fixed line 6326 as per your prior post.

By: Digium Subversion (svnbot) 2008-10-17 00:50:04

Repository: asterisk
Revision: 150426

U   trunk/CHANGES
U   trunk/UPGRADE.txt
U   trunk/channels/chan_skinny.c
U   trunk/configs/skinny.conf.sample

r150426 | mvanbaak | 2008-10-17 00:50:04 -0500 (Fri, 17 Oct 2008) | 8 lines

Break up skinny.conf into seperate sections for
devices and lines.

(closes issue ASTERISK-12674)
Reported by: wedhorn
     config-restruct-v4.diff uploaded by wedhorn (license 30)