Summary:ASTERISK-12673: [patch] undesired autoprune behavior might delete all your contacts
Reporter:Caio Begotti (caio1982)Labels:
Date Opened:2008-09-01 14:35:56Date Closed:2008-09-09 16:59:33
Versions:Frequency of
Environment:Attachments:( 0) res_jabber_autoprune1.diff
Description:I've tested the following scenario and, IMHO, the default autoprune should not be set on. It's too dangerous for the regular user or admin to be enabled for new installations. I don't see any clear reason to have it on, bear with me if it's really required (I'm not familiar with the Jabber spec).

I log in with my FOO account on Gmail/Gtalk and add 150 friends to my Jabber-based client, online. Then I register this very same account with res_jabber so I can make sure it's fully working and stuff. As soon Asterisk loads it up it sets a global AJI_AUTOPRUNE to true. Suddenly ALL my 150 contacts are gone on my Gtalk list. The only way to restore the list is to re-add them all (which is a PITA for my friends, not for me).

I've lost my all contacts when testing res_jabber due this, I hope autoprune is disabled by default in the next releases :-(


Yeah, the patch is very verbose. User information is never a bad thing.
Comments:By: Tilghman Lesher (tilghman) 2008-09-03 11:32:46

Looks good to me.  In fact, unless I hear otherwise, I think this should probably be included in 1.6.0, as well.

By: Caio Begotti (caio1982) 2008-09-09 08:15:40

Corydon, is there anything else missing or is it really ok for 1.6.0? :-)

By: Digium Subversion (svnbot) 2008-09-09 16:59:30

Repository: asterisk
Revision: 142280

U   trunk/CHANGES
U   trunk/configs/jabber.conf.sample
U   trunk/res/res_jabber.c

r142280 | phsultan | 2008-09-09 16:59:29 -0500 (Tue, 09 Sep 2008) | 6 lines

Disable autoprune by default.
(closes issue ASTERISK-12673)
Reported by: caio1982
     res_jabber_autoprune1.diff uploaded by caio1982 (license 22)
Tested by: caio1982