| Summary: | ASTERISK-12661: [patch] Channel name buffer is too small | ||
| Reporter: | Andriy I Pylypenko (bamby) | Labels: | |
| Date Opened: | 2008-08-29 03:40:18 | Date Closed: | 2008-11-13 15:23:56.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) manager.c.diff | |
| Description: | When doing Originate request using the Manager Interface the Channel attribute of the request contains the channel specification. The buffer for this data is AST_MAX_EXTENSION long, which is 80 bytes only, while for example a SIP channel specification can contain not only extension but also authname (can be quite long), password, md5 secret (32 bytes), hostname (MAXHOSTNAMELEN = 256) and port (5 bytes). So the buffer for SIP channel specification should be at least 462 bytes: channel name (3 bytes) + extension (80) + password or digest (at least 32) + autname (about 80 bytes) + hostname (256) + port (5) + delimiters (6) The patch (against trunk) attached. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-11-13 15:23:56.000-0600 Repository: asterisk Revision: 156688 U branches/1.4/main/manager.c ------------------------------------------------------------------------ r156688 | tilghman | 2008-11-13 15:23:55 -0600 (Thu, 13 Nov 2008) | 7 lines Provide more space for all the data which can appear in an originating channel name. (closes issue ASTERISK-12661) Reported by: bamby Patches: manager.c.diff uploaded by bamby (license 430) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=156688 | ||