[Home]

Summary:ASTERISK-12639: prompt tokens defined in followme.conf within followmeid prompt tokens are inconsistent
Reporter:Jim Sturtevant (jsturtevant)Labels:
Date Opened:2008-08-24 09:41:49Date Closed:2008-08-26 12:57:06
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_followme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:several of the tokens the parser is scanning for have followme-xxx.

example:
followme-norecording-prompt should be norecording-prompt

****** ADDITIONAL INFORMATION ******

/*! \brief Set parameter in profile from configuration file */
static void profile_set_param(struct call_followme *f, const char *param, const char *val, int linenum, int failunknown)
{

       if (!strcasecmp(param, "musicclass") || !strcasecmp(param, "musiconhold") || !strcasecmp(param, "music"))
               ast_copy_string(f->moh, val, sizeof(f->moh));
       else if (!strcasecmp(param, "context"))
               ast_copy_string(f->context, val, sizeof(f->context));
       else if (!strcasecmp(param, "takecall"))
               ast_copy_string(f->takecall, val, sizeof(f->takecall));
       else if (!strcasecmp(param, "declinecall"))
               ast_copy_string(f->nextindp, val, sizeof(f->nextindp));
       else if (!strcasecmp(param, "call-from-prompt"))
               ast_copy_string(f->callfromprompt, val, sizeof(f->callfromprompt));
       else if (!strcasecmp(param, "followme-norecording-prompt"))
               ast_copy_string(f->norecordingprompt, val, sizeof(f->norecordingprompt));
       else if (!strcasecmp(param, "followme-options-prompt"))
               ast_copy_string(f->optionsprompt, val, sizeof(f->optionsprompt));
       else if (!strcasecmp(param, "followme-pls-hold-prompt"))
               ast_copy_string(f->plsholdprompt, val, sizeof(f->plsholdprompt));
       else if (!strcasecmp(param, "followme-status-prompt"))
               ast_copy_string(f->statusprompt, val, sizeof(f->statusprompt));
       else if (!strcasecmp(param, "followme-sorry-prompt"))
               ast_copy_string(f->sorryprompt, val, sizeof(f->sorryprompt));
       else if (failunknown) {
               if (linenum >= 0)
                       ast_log(LOG_WARNING, "Unknown keyword in profile '%s': %s at line %d of followme.conf\n", f->name, param, l$
               else
                       ast_log(LOG_WARNING, "Unknown keyword in profile '%s': %s\n", f->name, param);
       }
}
Comments:By: Tilghman Lesher (tilghman) 2008-08-26 12:32:54

Given that this does not produce any bad behavior, I'm not inclined to change this at all in 1.4, but trunk is a possibility.
By: Digium Subversion (svnbot) 2008-08-26 12:57:04

Repository: asterisk
Revision: 140167

U   trunk/apps/app_followme.c
U   trunk/configs/followme.conf.sample

------------------------------------------------------------------------
r140167 | tilghman | 2008-08-26 12:57:04 -0500 (Tue, 26 Aug 2008) | 5 lines

Standardize the option names for consistency (but continue to work with the
existing names for backwards compatibility).
(closes issue ASTERISK-12639)
Reported by: jsturtevant

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=140167