[Home]

Summary:ASTERISK-12637: [patch] chan_local doesn't copy the dialplan (cid.cid_ton) into the new channel
Reporter:Peter Schlaile (peter schlaile)Labels:
Date Opened:2008-08-23 06:19:16Date Closed:2008-10-27 16:21:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_local
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080826__bug13368.diff.txt
Description:chan_local forgets to copy cid.cid_ton into the new channel thereby making
it impossible to hack around the missing support of cid_ton within chan_sip :)

the oneliner patch to fix this is attached in additional information.

****** ADDITIONAL INFORMATION ******

*code removed*
Comments:By: Peter Schlaile (peter schlaile) 2008-08-23 06:21:03

... the problem is still present in current SVN.
By: snuffy (snuffy) 2008-08-23 22:19:04

If you post any code changes it must be uploaded to the bug as a 'code/documentation' submission
By: Peter Schlaile (peter schlaile) 2008-08-24 03:05:10

... hm, don't have access to the machine right now.

But may I ask you something: am I right, that
just adding the little line by hand to the code might have
taken you less time than writing this silly comment?

Just a thought.

Sincerely,
Peter
By: Tilghman Lesher (tilghman) 2008-08-26 08:13:07

Peter:  while you may not be concerned about code copyright issues, it's a matter on our minds when it comes to being on the good side of the law.  While your patch may not have been copyrightable due to its size, we tend to err on the side of caution.
By: Tilghman Lesher (tilghman) 2008-08-26 08:17:52

Does this patch work for you?
By: Tilghman Lesher (tilghman) 2008-09-15 16:16:25

We need some testing here.
By: Digium Subversion (svnbot) 2008-10-27 16:21:09

Repository: asterisk
Revision: 152215

U   branches/1.4/channels/chan_local.c

------------------------------------------------------------------------
r152215 | tilghman | 2008-10-27 16:21:08 -0500 (Mon, 27 Oct 2008) | 6 lines

Inherit ALL elements of CallerID across a local channel.
(closes issue ASTERISK-12637)
Reported by: Peter Schlaile
Patches:
      20080826__bug13368.diff.txt uploaded by Corydon76 (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=152215