| Summary: | ASTERISK-12628: [patch] Incorrect checking of the "Channel" header on Originate action | ||
| Reporter: | Tomás Laureano Peralta Tormey (laureano) | Labels: | |
| Date Opened: | 2008-08-21 18:38:19 | Date Closed: | 2008-08-22 16:27:28 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) originate_channel_check.patch | |
| Description: | When an Originate action is sent to AMI without the "Channel" header, the error response from the server is "Invalid channel" but it should be "Channel not specified". This issue is produced by the incorrect check of the "Channel" header in the function action_originate in the file main/manager.c. The uploaded patches fixes this issue. ****** STEPS TO REPRODUCE ****** Connect to manager an issue an Originate action without the "Channel" header. ****** ADDITIONAL INFORMATION ****** Output from AMI: ================ tomas@newells:~$ telnet dev ami Trying 192.168.0.6... Connected to dev. Escape character is '^]'. Asterisk Call Manager/1.1 Action: Login Username: mark Secret: mysecret Response: Success Message: Authentication accepted Action: Originate Response: Error Message: Invalid channel Action: Logoff Response: Goodbye Message: Thanks for all the fish. Connection closed by foreign host. Output from patched AMI: ======================== tomas@newells:~$ telnet dev ami Trying 192.168.0.6... Connected to dev. Escape character is '^]'. Asterisk Call Manager/1.1 Action: Login Username: mark Secret: mysecret Response: Success Message: Authentication accepted Action: Originate Response: Error Message: Channel not specified Action: Logoff Response: Goodbye Message: Thanks for all the fish. Connection closed by foreign host. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-08-22 16:27:26 Repository: asterisk Revision: 139621 U branches/1.4/main/manager.c ------------------------------------------------------------------------ r139621 | jpeeler | 2008-08-22 16:27:25 -0500 (Fri, 22 Aug 2008) | 5 lines (closes issue ASTERISK-12628) Reported by: Laureano Patches: originate_channel_check.patch uploaded by Laureano (license 265) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=139621 | ||