[Home]

Summary:ASTERISK-12624: IAX variable feature does not work
Reporter:adomjan (adomjan)Labels:
Date Opened:2008-08-21 08:08:21Date Closed:2008-09-13 08:47:36
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080827__bug13354.diff.txt
( 1) 20080828__bug13354.diff.txt
( 2) 20080829__bug13354__1.6.0.diff.txt
Description:[Aug 21 15:06:29]     -- Executing [3622622223@select_route:22] Set("SIP/teszt-3622622222-11624170", "IAXVAR(foo)=1234") in new stack
[Aug 21 15:06:29]     -- Executing [3622622223@select_route:23] Dial("SIP/teszt-3622622222-11624170", "IAX2/ssp02/3622622223@our-users-internal,90,L(150000:5000)g") in new stack
[Aug 21 15:06:29]     -- Limit Data for this call:
[Aug 21 15:06:29]     -- Called ssp02/3622622223@our-users-internal
[Aug 21 15:06:29] Tx-Frame Retry[000] -- OSeqno: 000 ISeqno: 000 Type: IAX     Subclass: NEW    
[Aug 21 15:06:29]    Timestamp: 00018ms  SCall: 08750  DCall: 00000 [87.242.0.15:4569]
[Aug 21 15:06:29]    VERSION         : 2
[Aug 21 15:06:29]    CALLED NUMBER   : 3622622223
[Aug 21 15:06:29]    CODEC_PREFS     : (alaw)
[Aug 21 15:06:29]    CALLING NUMBER  : 3622622222
[Aug 21 15:06:29]    CALLING PRESNTN : 3
[Aug 21 15:06:29]    CALLING TYPEOFN : 0
[Aug 21 15:06:29]    CALLING TRANSIT : 0
[Aug 21 15:06:29]    CALLING NAME    : Teszt
[Aug 21 15:06:29]    LANGUAGE        : hu
[Aug 21 15:06:29]    CALLED CONTEXT  : our-users-internal
[Aug 21 15:06:29]    FORMAT          : 8
[Aug 21 15:06:29]    CAPABILITY      : 24584
[Aug 21 15:06:29]    ADSICPE         : 2
[Aug 21 15:06:29]    DATE TIME       : 2008-08-21  15:06:28
[Aug 21 15:06:29]


****** ADDITIONAL INFORMATION ******

I checked by wireshark, asterisk didn't insert the foo variable in the IAX NEW packet.
Comments:By: Tilghman Lesher (tilghman) 2008-08-27 18:31:38

As it turns out, it was broken within app_dial.  One line fix uploaded.
By: adomjan (adomjan) 2008-08-28 03:52:56

chan_iax sends the iaxvars now:
[Aug 28 10:57:01]    VARIABLE        : bk=000
[Aug 28 10:57:01]    VARIABLE        : sk=916
[Aug 28 10:57:01]    VARIABLE        : provider=etel-sip
[Aug 28 10:57:01]    VARIABLE        : route_name=etel-sip-link

but I can't read by ${IAXVAR()}
[Aug 28 10:57:01]     -- Executing [36309829188@internal-iax:1] NoOp("IAX2/ssp01-12393", "bk= sk=") in new stack

NoOP(bk=${IAXVAR(bk)} sk=${IAXVAR(sk)})
By: Tilghman Lesher (tilghman) 2008-08-28 17:57:25

Took a bit of work, but here's the updated patch.
By: adomjan (adomjan) 2008-08-29 03:15:52

I tryed apply this patch for asterisk-1.6.0 but failed:
patching file channels/chan_iax2.c
Hunk #1 succeeded at 628 (offset -27 lines).
Hunk #2 succeeded at 3712 (offset -33 lines).
Hunk #3 succeeded at 4167 (offset -89 lines).
Hunk #4 FAILED at 8289.
Hunk ASTERISK-1 FAILED at 8312.
Hunk ASTERISK-2 FAILED at 8341.
Hunk ASTERISK-3 succeeded at 8486 (offset 1 line).
Hunk ASTERISK-4 succeeded at 9124 (offset -94 lines).
Hunk ASTERISK-5 FAILED at 9185.
Hunk ASTERISK-6 succeeded at 9519 (offset -78 lines).
4 out of 10 hunks FAILED -- saving rejects to file channels/chan_iax2.c.rej
patching file channels/iax2-parser.c
Hunk #1 FAILED at 923.
1 out of 1 hunk FAILED -- saving rejects to file channels/iax2-parser.c.rej

I tryed to apply patch manualy, but failed, you are using the ast_datastore_alloc function which is not available in the 1.6.0 only in the trunk.
By: Tilghman Lesher (tilghman) 2008-08-29 07:42:12

You can substitute ast_channel_datastore_alloc for that.  Sorry, due to the merge order, I tend to develop patches against trunk first, because that is the order in which patches need to be merged.
By: adomjan (adomjan) 2008-08-29 08:10:23

Ok, I'll have time on monday to do it and test it.
By: Tilghman Lesher (tilghman) 2008-09-12 18:24:23

adomjan:  it's been 2 weeks.  Have you tested this yet?
By: adomjan (adomjan) 2008-09-12 18:38:21

sorry, I was busy I promise I will test try it on next week.
By: adomjan (adomjan) 2008-09-13 04:12:18

It is ok now! Thanks!
By: Digium Subversion (svnbot) 2008-09-13 08:44:46

Repository: asterisk
Revision: 143031

U   trunk/apps/app_dial.c
U   trunk/channels/chan_iax2.c
U   trunk/channels/iax2-parser.c

------------------------------------------------------------------------
r143031 | tilghman | 2008-09-13 08:44:44 -0500 (Sat, 13 Sep 2008) | 8 lines

Repair IAXVAR implementation so that it works again (regression?)
(closes issue ASTERISK-12624)
Reported by: adomjan
Patches:
      20080828__bug13354.diff.txt uploaded by Corydon76 (license 14)
      20080829__bug13354__1.6.0.diff.txt uploaded by Corydon76 (license 14)
Tested by: Corydon76, adomjan

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=143031
By: Digium Subversion (svnbot) 2008-09-13 08:47:35

Repository: asterisk
Revision: 143032

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_dial.c
U   branches/1.6.0/channels/chan_iax2.c
U   branches/1.6.0/channels/iax2-parser.c

------------------------------------------------------------------------
r143032 | tilghman | 2008-09-13 08:47:34 -0500 (Sat, 13 Sep 2008) | 15 lines

Recorded merge of revisions 143031 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r143031 | tilghman | 2008-09-13 08:54:15 -0500 (Sat, 13 Sep 2008) | 8 lines
 
 Repair IAXVAR implementation so that it works again (regression?)
 (closes issue ASTERISK-12624)
  Reported by: adomjan
  Patches:
        20080828__bug13354.diff.txt uploaded by Corydon76 (license 14)
        20080829__bug13354__1.6.0.diff.txt uploaded by Corydon76 (license 14)
  Tested by: Corydon76, adomjan
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=143032