[Home]

Summary:ASTERISK-12449: [patch] Hebrew support for app_voicemail
Reporter:Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech)Labels:
Date Opened:2008-07-24 18:32:15Date Closed:2010-01-04 15:59:18.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail.c.multi-lang-patch
( 1) app_voicemail.c.patch
( 2) hebrew.ods
( 3) voicemail-hebrew-patch-1.4-SVN.c.patch
Description:The following contains a patch to support the Hebrew language in app_voicemail, using a correct hebrew grammatical structure. This patch is a cleanup of a pervious patch which was not accepted with the say.c patch before.
Comments:By: Tilghman Lesher (tilghman) 2008-07-25 08:38:23

I also need the modification to the doc/lang/hebrew.ods sheet, for any new sounds (e.g. vm-shtei) introduced with this patch.  You may simply upload the new .ods file, since it is a binary format.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-07-25 08:45:28

updated ods file uploaded. The previous ods file includes all the related filenames and texts already.
By: Digium Subversion (svnbot) 2008-07-25 17:00:12

Repository: asterisk
Revision: 133904

U   trunk/apps/app_voicemail.c
U   trunk/doc/lang/hebrew.ods

------------------------------------------------------------------------
r133904 | tilghman | 2008-07-25 17:00:11 -0500 (Fri, 25 Jul 2008) | 7 lines

Hebrew syntax for voicemail prompts
(closes issue ASTERISK-12449)
Reported by: greenfieldtech
Patches:
      app_voicemail.c.patch uploaded by greenfieldtech (license 369)
      hebrew.ods uploaded by greenfieldtech (license 369)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=133904
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-07-26 01:47:44

Can you please also apply the patch to branch 1.4? the previous patch was applied to both branches, and I'd really like to see all these patches going into the next  1.4 version and the 1.6 release.
By: Paul Belanger (pabelanger) 2008-07-26 11:34:27

greenfieldtech: It was backported to the 1.6 branch (http://svn.digium.com/view/asterisk?view=rev&revision=133905).  I'm not sure you'll see it in 1.4 as it is a new feature.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-07-26 14:29:37

Hmmmm... so what do I need to do in order to get into the 1.4 branch as well?

I understand this is a new feature, but while 1.4 enjoys proper number syntax, it lacks proper voicemail syntax. The same also applies to queues and meetme, which I'm currently working on.

If I'm required to create a new patch for the 1.4 branch, no problem, I'll do it.
By: Tilghman Lesher (tilghman) 2008-08-07 11:25:45

You'd need to create a patch specifically for 1.4, as the current patch does not apply cleanly.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-08-07 11:53:13

No problem, I'll create a patch for 1.4 branch too.
By: Tilghman Lesher (tilghman) 2008-09-11 17:47:11

greenfieldtech:  have you created a patch for 1.4 yet?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-09-12 04:47:14

Hi Corydon,

Real life kind'a caught up with me these past few weeks. I'll be doing this patch,
while attending Astricon 2008.

C'ya there.

Nir
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-09-24 17:10:42

Hi Corydon,

Just uploaded a patch for version 1.4 for app_voicemail.
The patch is against SVN-branch-1.4-r144238M

Nir
By: Digium Subversion (svnbot) 2008-09-24 20:34:50

Repository: asterisk
Revision: 144356

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r144356 | tilghman | 2008-09-24 20:34:49 -0500 (Wed, 24 Sep 2008) | 6 lines

Backport Hebrew language to voicemail.
(closes issue ASTERISK-12449)
Reported by: greenfieldtech
Patches:
      voicemail-hebrew-patch-1.4-SVN.c.patch uploaded by greenfieldtech (license 369)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=144356
By: Digium Subversion (svnbot) 2008-09-24 20:36:16

Repository: asterisk
Revision: 144357

_U  trunk/

------------------------------------------------------------------------
r144357 | tilghman | 2008-09-24 20:36:15 -0500 (Wed, 24 Sep 2008) | 13 lines

Recorded merge of revisions 144356 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r144356 | tilghman | 2008-09-24 20:44:47 -0500 (Wed, 24 Sep 2008) | 6 lines
 
 Backport Hebrew language to voicemail.
 (closes issue ASTERISK-12449)
  Reported by: greenfieldtech
  Patches:
        voicemail-hebrew-patch-1.4-SVN.c.patch uploaded by greenfieldtech (license 369)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=144357
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-12-18 17:57:03.000-0600

Can someone please make sure this makes it to 1.4.23? It was missed in 1.4.22, and people are really waiting for this in Israel.
By: Leif Madsen (lmadsen) 2008-12-18 19:38:37.000-0600

greenfieldtech: can you test 1.4.23-rc4 and make sure it is there?
By: Leif Madsen (lmadsen) 2008-12-19 10:09:57.000-0600

Actually this wasn't missed in 1.4.22, as Asterisk-1.4.22-rc5 was branched off on Sept. 9th, and 1.4.22 was created from that release.

This change went into SVN on Sept. 24th, so thus, it should be in 1.4.23.

I mispoke when I said 1.4.23-rc4 (that tag does not exist). I meant 1.4.23-rc3 which was released 2 days ago.

However, if you look at the ChangeLog, you will notice some logs were missed between Sept. 9th and Oct. 1st. This is simply a script issue that will be addressed in the future.

If you find that the feature is not available in 1.4.23-rc3, then please find a bug marshall in #asterisk-bug on the Freenode IRC network at irc.freenode.net.

Thanks!
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2009-05-02 08:40:49

Looks like the patch that I submitted before for TRUNK 1.4 has a small bug in it - it caused situation where a certain message got played twice. The following patch corrects that, and also orders the language selection for play_message.
The patch is now called multi-lang :-)


By: Digium Subversion (svnbot) 2009-05-02 13:48:21

Repository: asterisk
Revision: 191778

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r191778 | mmichelson | 2009-05-02 13:48:21 -0500 (Sat, 02 May 2009) | 11 lines

Fix a bug which resulted from the Hebrew voicemail commit.

This fixes a case where a certain message could get played twice.

(closes issue ASTERISK-12449)
Reported by: greenfieldtech
Patches:
     app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369)
Tested by: greenfieldtech


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=191778
By: Digium Subversion (svnbot) 2009-05-02 13:54:53

Repository: asterisk
Revision: 191781

_U  trunk/

------------------------------------------------------------------------
r191781 | mmichelson | 2009-05-02 13:54:52 -0500 (Sat, 02 May 2009) | 16 lines

Blocked revisions 191778 via svnmerge

........
 r191778 | mmichelson | 2009-05-02 13:48:20 -0500 (Sat, 02 May 2009) | 11 lines
 
 Fix a bug which resulted from the Hebrew voicemail commit.
 
 This fixes a case where a certain message could get played twice.
 
 (closes issue ASTERISK-12449)
 Reported by: greenfieldtech
 Patches:
       app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369)
 Tested by: greenfieldtech
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=191781
By: Digium Subversion (svnbot) 2009-05-02 13:55:17

Repository: asterisk
Revision: 191782

_U  branches/1.6.0/

------------------------------------------------------------------------
r191782 | mmichelson | 2009-05-02 13:55:17 -0500 (Sat, 02 May 2009) | 22 lines

Blocked revisions 191781 via svnmerge

................
 r191781 | mmichelson | 2009-05-02 13:54:52 -0500 (Sat, 02 May 2009) | 16 lines
 
 Blocked revisions 191778 via svnmerge
 
 ........
   r191778 | mmichelson | 2009-05-02 13:48:20 -0500 (Sat, 02 May 2009) | 11 lines
   
   Fix a bug which resulted from the Hebrew voicemail commit.
   
   This fixes a case where a certain message could get played twice.
   
   (closes issue ASTERISK-12449)
   Reported by: greenfieldtech
   Patches:
         app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369)
   Tested by: greenfieldtech
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=191782
By: Digium Subversion (svnbot) 2009-05-02 13:55:54

Repository: asterisk
Revision: 191783

_U  branches/1.6.1/

------------------------------------------------------------------------
r191783 | mmichelson | 2009-05-02 13:55:54 -0500 (Sat, 02 May 2009) | 22 lines

Blocked revisions 191781 via svnmerge

................
 r191781 | mmichelson | 2009-05-02 13:54:52 -0500 (Sat, 02 May 2009) | 16 lines
 
 Blocked revisions 191778 via svnmerge
 
 ........
   r191778 | mmichelson | 2009-05-02 13:48:20 -0500 (Sat, 02 May 2009) | 11 lines
   
   Fix a bug which resulted from the Hebrew voicemail commit.
   
   This fixes a case where a certain message could get played twice.
   
   (closes issue ASTERISK-12449)
   Reported by: greenfieldtech
   Patches:
         app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369)
   Tested by: greenfieldtech
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=191783
By: Digium Subversion (svnbot) 2009-05-02 13:56:11

Repository: asterisk
Revision: 191784

_U  branches/1.6.2/

------------------------------------------------------------------------
r191784 | mmichelson | 2009-05-02 13:56:11 -0500 (Sat, 02 May 2009) | 22 lines

Blocked revisions 191781 via svnmerge

................
 r191781 | mmichelson | 2009-05-02 13:54:52 -0500 (Sat, 02 May 2009) | 16 lines
 
 Blocked revisions 191778 via svnmerge
 
 ........
   r191778 | mmichelson | 2009-05-02 13:48:20 -0500 (Sat, 02 May 2009) | 11 lines
   
   Fix a bug which resulted from the Hebrew voicemail commit.
   
   This fixes a case where a certain message could get played twice.
   
   (closes issue ASTERISK-12449)
   Reported by: greenfieldtech
   Patches:
         app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369)
   Tested by: greenfieldtech
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=191784
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2009-12-02 07:31:45.000-0600

Hi all,

This patch has been in trunk since May this year, however, till now none of the Hebrew patches had been transferred into the 1.6.0.X release. It is integrated into 1.6.1.X and 1.6.2.X.

Can this be integrated into 1.6.0.X ?

Nir
By: Tilghman Lesher (tilghman) 2010-01-04 15:58:47.000-0600

It appears that Hebrew was integrated into app_voicemail in 1.6.0 in revision 232864.