| Summary: | ASTERISK-12446: [patch] extending the support of ATTENDED_TRANSFER_COMPLETE_SOUND for more channel types | ||
| Reporter: | Caio Begotti (caio1982) | Labels: | |
| Date Opened: | 2008-07-24 14:29:04 | Date Closed: | 2008-07-30 11:32:36 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) atxfer_complete_sound3.diff | |
| Description: | As of today only SIP channels supports the channel variable ATTENDED_TRANSFER_COMPLETE_SOUND, which indicates a sound file to be played upon transfered calls. This patch try to make IAX, Skinny and DAHDI channels capable of that since they all support 'setvar' (tested with SIP to make sure at least this one hasn't been broken). The peer who made the transfer by default hears the pbx-transfer sound and the third peer receiving the call hears 'xfersound' from features.conf, while the transfered party does not hear anything. By using this variable now the transfered party will hear the sound file from it too. ****** ADDITIONAL INFORMATION ****** It's a complement for ASTERISK-8972 which has been closed when file added it to chan_sip. | ||
| Comments: | By: Caio Begotti (caio1982) 2008-07-30 09:09:12 Is there any design or code problem with the attached patch or it's ok as is? By: Tilghman Lesher (tilghman) 2008-07-30 11:23:18 No, I think this is how it probably should have been implemented in the first place. By: Digium Subversion (svnbot) 2008-07-30 11:32:34 Repository: asterisk Revision: 134401 U trunk/CHANGES U trunk/channels/chan_sip.c U trunk/configs/chan_dahdi.conf.sample U trunk/configs/iax.conf.sample U trunk/configs/sip.conf.sample U trunk/configs/skinny.conf.sample U trunk/main/features.c ------------------------------------------------------------------------ r134401 | tilghman | 2008-07-30 11:32:34 -0500 (Wed, 30 Jul 2008) | 7 lines Move implementation of an attended-transfer-complete sound from one channel driver into a common place for multiple channel drivers. (closes issue ASTERISK-12446) Reported by: caio1982 Patches: atxfer_complete_sound3.diff uploaded by caio1982 (license 22) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=134401 | ||