[Home]

Summary:ASTERISK-12436: Parking with hints enabled crashes Asterisk
Reporter:Kristian Kielhofner (krisk84)Labels:
Date Opened:2008-07-23 11:28:49Date Closed:2008-10-09 14:17:19
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bug13139.patch
( 1) extensions.conf
( 2) features.conf
( 3) parkcrash-asterisk-1.4.21.1-bt.txt
( 4) parkcrash-asterisk-1.4.21.1-bt-no-optimize.txt
( 5) parkcrash-asterisk-1.4.21.1-bt-no-optimize2.txt
( 6) parkcrash-asterisk-1.4.21.1-bt-no-optimize3.txt
( 7) sip.conf
Description:Extension 101 calls Extension 100.
Extension 100 answers.
Extension 100 transfers to 7000 (Park).

While the park position is being read back (7-0-0-1), Extension 102
dials 7001 to pick up the parked call.  As the park position finishes
being read back, it crashes (sometimes).  It is our belief that if the timing could be executed perfectly it would crash more consistently (always).

Parking behaves strangely with hints disabled but does not crash Asterisk (at least we couldn't make it happen here).
Comments:By: Kristian Kielhofner (krisk84) 2008-07-23 11:30:44

Oops, ignore the SVN Branch selection.  This was Asterisk 1.4.21.1.
By: Russell Bryant (russell) 2008-07-30 15:36:52

Is this backtrace from a build with DONT_OPTIMIZE turned on?
By: Kristian Kielhofner (krisk84) 2008-08-01 11:13:34

This time, it is.  Hopefully from no-optimize + 2 + 3 you can get the information you need.  Every time I've tried to upload these files mantis comes back with:

APPLICATION ERROR ASTERISK-2171

Could not find a tag with that name.
By: Kristian Kielhofner (krisk84) 2008-10-02 11:46:40

Any updates here?
By: Jeff Peeler (jpeeler) 2008-10-02 11:57:55

I literally just took the issue, but it looks like I can reproduce the crash.
By: Kristian Kielhofner (krisk84) 2008-10-02 12:07:34

That's good news. Let me know if you need anything else from me. Thanks!
By: Giorgio Incantalupo (gincantalupo) 2008-10-03 08:41:21

I'm trying asterisk 1.4.22-rc5 and it crashes when parking. The patch I downloaded from issue ASTERISK-1190979 has not been completely applied: res_agi.c needs to be patched. I made a visual inspection of svn version and it seems it has the same problem.
By: Jeff Peeler (jpeeler) 2008-10-03 11:00:02

gincantalupo: No, that was not that proper fix and was reverted. A different fix will be merged soon.
By: Jeff Peeler (jpeeler) 2008-10-03 12:15:45

In fact, I'm going to delete the res_agi patch to avoid confusion.
By: Jeff Peeler (jpeeler) 2008-10-03 12:25:21

I first solved this issue without worrying about hints. Now using hints and my patch I don't see any remaining problems. Check to see if it fixes things for you too.
By: Kristian Kielhofner (krisk84) 2008-10-03 12:47:04

We'll let you know shortly - thanks!
By: Jeff Peeler (jpeeler) 2008-10-08 14:47:57

Any testing results on this yet?
By: Kristian Kielhofner (krisk84) 2008-10-08 15:03:12

Perfect timing, just finished them up today.  Looks good from here, thanks!
By: Digium Subversion (svnbot) 2008-10-09 13:45:47

Repository: asterisk
Revision: 147941

U   branches/1.4/res/res_features.c

------------------------------------------------------------------------
r147941 | jpeeler | 2008-10-09 13:45:47 -0500 (Thu, 09 Oct 2008) | 6 lines

(closes issue ASTERISK-12436)
Reported by: krisk84
Tested by: krisk84

This change prevents a call that is placed in the parkinglot to be picked up before the PBX is finished. If another extension dials the parking extension before the PBX thread has completed at minimum warnings will occur about the PBX not properly being terminated. At worse, a crash could occur.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=147941
By: Digium Subversion (svnbot) 2008-10-09 14:17:16

Repository: asterisk
Revision: 147952

U   trunk/main/features.c

------------------------------------------------------------------------
r147952 | jpeeler | 2008-10-09 14:17:15 -0500 (Thu, 09 Oct 2008) | 6 lines

(closes issue ASTERISK-12436)
Reported by: krisk84
Tested by: krisk84

This change prevents a call that is placed in the parkinglot to be picked up before the PBX is finished. If another extension dials the parking extension before the PBX thread has completed at minimum warnings will occur about the PBX not properly being terminated. At worst, a crash could occur.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=147952