Summary:	ASTERISK-12430: [patch] Some fixes to autocompletion in some commands.
Reporter:	Eliel Sardanons (eliel)	Labels:
Date Opened:	2008-07-22 17:34:32	Date Closed:	2008-09-06 06:53:52
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) clichanges.patch
Description:	Changes applied by this patch: - Fix autocompletion in 'sip prune realtime', sip peers where never auto completed. Now we complete this command with:         'sip prune realtime peer' -> all | like | sip peers  Also I have modified the syntax in the usage, was wrong...     - Pass ast_cli_args->argv and ast_cli_args->argc while running autocompletion on CLI commands (CLI_GENERATE).      With this we avoid comparisons on ast_cli_args->line like this:         strcasestr(a->line, " description")         strcasestr(a->line, "descriptions ")         strcasestr(a->line, "realtime peer"), and so on..      Making the code more confusing (check the spaces in description!).      The only thing we must be sure is to first check a->pos or a->argc.       - Fix 'iax2 prune realtime' autocompletion, now we autocomplete this command with 'all' & 'iax2 peers', check a look that iax2 peers where all the peers, now only the ones in the cache..  (For this I have changed function complete_iax2_peers to support flags, like complete_sip_peers).
Comments:	By: Digium Subversion (svnbot) 2008-09-06 06:53:50 Repository: asterisk Revision: 141464 U   trunk/channels/chan_iax2.c U   trunk/channels/chan_sip.c U   trunk/main/cli.c ------------------------------------------------------------------------ r141464 | mvanbaak | 2008-09-06 06:53:48 -0500 (Sat, 06 Sep 2008) | 23 lines Some fixes to autocompletion in some commands. Changes applied by this patch: - Fix autocompletion in 'sip prune realtime', sip peers where never auto completed. Now we complete this command with:  'sip prune realtime peer' -> all | like | sip peers  Also I have modified the syntax in the usage, was wrong... - Pass ast_cli_args->argv and ast_cli_args->argc while running autocompletion on CLI commands (CLI_GENERATE).  With this we avoid comparisons on ast_cli_args->line like this:  strcasestr(a->line, " description")  strcasestr(a->line, "descriptions ")  strcasestr(a->line, "realtime peer"), and so on..  Making the code more confusing (check the spaces in description!).  The only thing we must be sure is to first check a->pos or a->argc.       - Fix 'iax2 prune realtime' autocompletion, now we autocomplete this command with 'all' & 'iax2 peers', check a look that iax2 peers where all the peers, now only the ones in the cache.. (closes issue ASTERISK-12430) Reported by: eliel Patches:      clichanges.patch uploaded by eliel (license 64) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=141464