| Summary: | ASTERISK-12413: [patch] Can't build RPM with 1.4.21.1 (few errors & fix) | ||
| Reporter: | sybasesql (sybasesql) | Labels: | |
| Date Opened: | 2008-07-19 22:38:52 | Date Closed: | 2008-09-08 15:06:28 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk.spec.diff | |
| Description: | Can't build RPM with asterisk 1.4.21.1 on: OS: CentOS 5.2 Arch: x64 1. Error in asterisk.spec - "make rpm" build error: ------- error: Legacy syntax is unsupported: copyright error: line 6: Unknown tag: Copyright: Linux Support Services, inc. ------- Fix: Line: Copyright: Linux Support Services, inc. Should be: License: Linux Support Services, inc. 2. Error in asterisk.spec - "make rpm" build error: ------- RPM build errors: File not found: /tmp/asterisk/var/lib/asterisk/mohmp3 File not found by glob: /tmp/asterisk/var/lib/asterisk/mohmp3/* ------- Fix: Lines: %attr(0755,root,root) %dir /var/lib/asterisk/mohmp3 %attr(0644,root,root) /var/lib/asterisk/mohmp3/* Should be: #%attr(0755,root,root) %dir /var/lib/asterisk/mohmp3 #%attr(0644,root,root) /var/lib/asterisk/mohmp3/* 3. Error in asterisk.spec - "make rpm" build error: ------- RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/asterisk.h /usr/sbin/aelparse /usr/sbin/muted /usr/sbin/rasterisk /var/lib/asterisk/moh/.asterisk-moh-freeplay-wav /var/lib/asterisk/moh/LICENSE-asterisk-moh-freeplay-wav /var/lib/asterisk/moh/fpm-calm-river.wav /var/lib/asterisk/moh/fpm-sunshine.wav /var/lib/asterisk/moh/fpm-world-mix.wav /var/lib/asterisk/sounds/.asterisk-core-sounds-en-gsm-1.4.9 /var/lib/asterisk/sounds/CHANGES-asterisk-core-en-1.4.9 /var/lib/asterisk/sounds/CREDITS-asterisk-core-en-1.4.9 /var/lib/asterisk/sounds/core-sounds-en.txt /var/lib/asterisk/sounds/followme/call-from.gsm /var/lib/asterisk/sounds/followme/no-recording.gsm /var/lib/asterisk/sounds/followme/options.gsm /var/lib/asterisk/sounds/followme/pls-hold-while-try.gsm /var/lib/asterisk/sounds/followme/sorry.gsm /var/lib/asterisk/sounds/followme/status.gsm /var/lib/asterisk/static-http/ajamdemo.html /var/lib/asterisk/static-http/astman.css /var/lib/asterisk/static-http/astman.js /var/lib/asterisk/static-http/prototype.js ------- Fix: Add lines to asterisk.spec: %attr(0644,root,root) /usr/include/asterisk.h %attr(0644,root,root) /usr/sbin/aelparse %attr(0644,root,root) /usr/sbin/muted %attr(0644,root,root) /usr/sbin/rasterisk %attr(0755,root,root) %dir /var/lib/asterisk/moh %attr(0644,root,root) /var/lib/asterisk/moh/.* %attr(0644,root,root) /var/lib/asterisk/moh/* %attr(0644,root,root) /var/lib/asterisk/sounds/.asterisk-core-sounds-en-gsm-1.4.9 %attr(0644,root,root) /var/lib/asterisk/sounds/CHANGES-asterisk-core-en-1.4.9 %attr(0644,root,root) /var/lib/asterisk/sounds/CREDITS-asterisk-core-en-1.4.9 %attr(0644,root,root) /var/lib/asterisk/sounds/core-sounds-en.txt %attr(0755,root,root) %dir /var/lib/asterisk/sounds/followme %attr(0644,root,root) /var/lib/asterisk/sounds/followme/*.gsm %attr(0755,root,root) %dir /var/lib/asterisk/static-http %attr(0644,root,root) /var/lib/asterisk/static-http/* | ||
| Comments: | By: snuffy (snuffy) 2008-07-20 16:12:47 Can you please attach any code/rpm changes as an attachment. As all code changes require a license to be valid By: Tilghman Lesher (tilghman) 2008-07-29 11:37:50 These changes aren't expressive, but merely functional, and therefore, they are not subject to copyright. Nevertheless, a diff file is preferred, and we'd prefer if you had a license on file. By: sybasesql (sybasesql) 2008-08-03 16:23:13 6c6 < License: Linux Support Services, inc. --- > Copyright: Linux Support Services, inc. 93,111c93,94 < #%attr(0755,root,root) %dir /var/lib/asterisk/mohmp3 < #%attr(0644,root,root) /var/lib/asterisk/mohmp3/* < # < %attr(0644,root,root) /usr/include/asterisk.h < %attr(0644,root,root) /usr/sbin/aelparse < %attr(0644,root,root) /usr/sbin/muted < %attr(0644,root,root) /usr/sbin/rasterisk < %attr(0755,root,root) %dir /var/lib/asterisk/moh < %attr(0644,root,root) /var/lib/asterisk/moh/.* < %attr(0644,root,root) /var/lib/asterisk/moh/* < %attr(0644,root,root) /var/lib/asterisk/sounds/.asterisk-core-sounds-en-gsm-1.4.9 < %attr(0644,root,root) /var/lib/asterisk/sounds/CHANGES-asterisk-core-en-1.4.9 < %attr(0644,root,root) /var/lib/asterisk/sounds/CREDITS-asterisk-core-en-1.4.9 < %attr(0644,root,root) /var/lib/asterisk/sounds/core-sounds-en.txt < %attr(0755,root,root) %dir /var/lib/asterisk/sounds/followme < %attr(0644,root,root) /var/lib/asterisk/sounds/followme/*.gsm < %attr(0755,root,root) %dir /var/lib/asterisk/static-http < %attr(0644,root,root) /var/lib/asterisk/static-http/* < # --- > %attr(0755,root,root) %dir /var/lib/asterisk/mohmp3 > %attr(0644,root,root) /var/lib/asterisk/mohmp3/* By: Michiel van Baak (mvanbaak) 2008-08-03 17:16:29 sybasesql: can you please upload the changes as an attachement ? While on it, please use 'svn diff' or 'diff -ruN' to create a unified diff. Easier to read etc :) By: Michiel van Baak (mvanbaak) 2008-08-03 17:30:59 thank you. Now it's a matter of time before your license is accepted and we can apply it. Karma added for the prompt replies By: Tzafrir Cohen (tzafrir) 2008-08-19 02:45:32 Why do you want to explicitly specify file permissions? The default permissions are OK. Just drop the %attr() where they are not explicitly required. By: Digium Subversion (svnbot) 2008-09-08 15:06:24 Repository: asterisk Revision: 141741 U branches/1.4/Makefile D branches/1.4/redhat/ ------------------------------------------------------------------------ r141741 | qwell | 2008-09-08 15:06:23 -0500 (Mon, 08 Sep 2008) | 8 lines Remove RPM package targets from Makefile (and all associated parts). This has never worked in 1.4, and we decided that it makes no sense to be done here. There are many distros out there that already have "proper" spec files that can be (re)used. Closes issue ASTERISK-12413 Closes issue DAHLIN-10 Closes issue ASTERISK-10503 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=141741 | ||