| Summary: | ASTERISK-12384: [patch] channel variable SENDTEXTSTATUS is not being set if the channel doesn't support send_text | ||
| Reporter: | Eliel Sardanons (eliel) | Labels: | |
| Date Opened: | 2008-07-15 13:45:06 | Date Closed: | 2008-07-21 15:46:36 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_sendtext |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_sendtext.c.patch ( 1) app_sendtext1.4.c | |
| Description: | If the channel does not implements send_text, the SENDTEXTSTATUS is supposed to be set to UNSUPPORTED and is not being set to that value, also, the documentation of SendText tells you about optional [,options] parameter, but there are no options accepted. | ||
| Comments: | By: Michiel van Baak (mvanbaak) 2008-07-19 06:21:29 I'm not sure we should remove the options param. I know it's not used, but it is already there and maybe it will be used in the future. By: Eliel Sardanons (eliel) 2008-07-19 11:52:55 We are talking about 10 lines of code, making the application confuse to everyone that reads it, we aren't loosing too much code, i think that the code should be clean enough without giving the developers the possibility of confusing. My 2 cents. By: Eliel Sardanons (eliel) 2008-07-19 12:01:11 If you think the code should not be removed, at least we should cleanup the syntax SendText(text) removing [,options]. By: Eliel Sardanons (eliel) 2008-07-21 11:32:51 patch for 1.4 branch uploaded. (Only fixing the channel variable issue and not removing any syntax documentation). By: Digium Subversion (svnbot) 2008-07-21 15:43:56 Repository: asterisk Revision: 132507 U branches/1.4/apps/app_sendtext.c ------------------------------------------------------------------------ r132507 | bbryant | 2008-07-21 15:43:54 -0500 (Mon, 21 Jul 2008) | 9 lines Fix a bug where SENDTEXTSTATUS isn't set properly when it isn't supported on a channel (yet _another_ useful patch by eliel). (issue ASTERISK-12384) Reported by: eliel Patches: app_sendtext1.4.c uploaded by eliel (license 64) Tested by: eliel ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=132507 By: Digium Subversion (svnbot) 2008-07-21 15:46:17 Repository: asterisk Revision: 132508 U trunk/apps/app_sendtext.c ------------------------------------------------------------------------ r132508 | bbryant | 2008-07-21 15:46:16 -0500 (Mon, 21 Jul 2008) | 9 lines Fix a bug where SENDTEXTSTATUS isn't set properly when it isn't supported on a channel (yet _another_ useful patch by eliel). (closes issue ASTERISK-12384) Reported by: eliel Patches: app_sendtext.c.patch uploaded by eliel (license 64) Tested by: eliel ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=132508 | ||