[Home]

Summary:ASTERISK-12383: [patch] in ast_cdr_setapp if (!app) app = NULL; if (!data) data = NULL; is redondant with following uses of S_OR
Reporter:Guillaume Knispel (gknispel_proformatique)Labels:
Date Opened:2008-07-15 12:23:37Date Closed:2008-07-15 12:39:26
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) trunk_ast_cdr_setapp.patch
Description:One does not need to do a :

if (!app)
 app = "";

when the only following use of app is through S_OR(app, "")

Same thing for data.
Comments:By: Guillaume Knispel (gknispel_proformatique) 2008-07-15 12:24:53

Same thing can be done for 1.4
By: Digium Subversion (svnbot) 2008-07-15 12:39:25

Repository: asterisk
Revision: 131012

U   branches/1.4/main/cdr.c

------------------------------------------------------------------------
r131012 | mvanbaak | 2008-07-15 12:39:24 -0500 (Tue, 15 Jul 2008) | 7 lines

remove 4 lines of redundant code.

(closes issue ASTERISK-12383)
Reported by: gknispel_proformatique
Patches:
     trunk_ast_cdr_setapp.patch uploaded by gknispel (license 261)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=131012