Summary: | ASTERISK-12370: [patch] add some const qualifiers | ||
Reporter: | Guillaume Knispel (gknispel_proformatique) | Labels: | |
Date Opened: | 2008-07-12 20:11:46 | Date Closed: | 2011-06-07 14:07:52 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk_trunk_const.patch | |
Description: | The attached patch adds some const qualifiers were applicable. It is not yet finished (the whole code base has not been completely reviewed) but seems usable by itself without breaking the build. | ||
Comments: | By: Tilghman Lesher (tilghman) 2008-07-13 11:35:16 1) Please don't add the const keyword to casts. It does absolutely nothing. 2) We are very cautious about altering public APIs, because it affects backwards compatibility, especially on function pointers. Please do not make those changes without discussion on the -dev list. 3) Please do not remove existing casts. They are there for good reason (mostly for compatibility with other architectures). By: Tilghman Lesher (tilghman) 2008-08-06 13:00:10 As there have been no updates to this patch in 3 weeks, I am suspending the issue. If you are able to provide an updated patch that addresses the listed issues, then please reopen this issue. If you need assistance, please ask a bug marshal in #asterisk-bugs on the Freenode IRC network. |