Summary:ASTERISK-12272: [patch] Dialog state NOTIFY for hold uses badly formed XML
Reporter:gowen72 (gowen72)Labels:
Date Opened:2008-06-27 19:09:16Date Closed:2008-07-01 02:42:08
Versions:Frequency of
Environment:Attachments:( 0) hold.patch
Description:For DIALOG_INFO_XML subscriptions, asterisk generates malformed XML for the hold state NOTIFY events.

The problem is that the XML tag added to indicate the hold state (the sip.rendering attribute) is not being terminated.  Since there is no value for this tag, it should be self-terminated, in the same way you are supposed to use "<hr/>" for a horizontal ruler in HTML.

Here is what is being sent:

 <param pname="+sip.rendering" pvalue="no">

But it shoud be:

 <param pname="+sip.rendering" pvalue="no"/>

Note the "/" character prior the closing ">".

Comments:By: Digium Subversion (svnbot) 2008-07-01 02:42:04

Repository: asterisk
Revision: 126735

U   branches/1.4/channels/chan_sip.c

r126735 | oej | 2008-07-01 02:42:00 -0500 (Tue, 01 Jul 2008) | 7 lines

Fix bad XML for hold notification.
Reported by: gowen72
     hold.patch uploaded by gowen72 (license 432)
(closes issue ASTERISK-12272)