Summary:	ASTERISK-12254: ap_queue does not call the application specified in monitor_exec when monitor_type=monitor
Reporter:	snyfer (snyfer)	Labels:
Date Opened:	2008-06-24 01:43:13	Date Closed:	2008-06-26 19:08:44
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	In Asterisk v1.6 Beta 9 ap_queue does not call the application specified in monitor_exec when monitor_type = monitor. when monitor_type = mixmonitor everything works fine! Because of that, it is not longer possible to record a call using monitor option from ap_queue and then create a stereo mp3 file with soxmix!
Comments:	By: Mark Michelson (mmichelson) 2008-06-24 12:24:25 The reason for this is that the monitor-join option has been removed from app_queue in favor of using MixMonitor for mixing files. Please see UPGRADE-1.4.txt in the Asterisk source directory. For now, I'm closing this bug since the feature you reference was purposefully removed. I would be open for reinstating the feature if users express interest in having it back in. By: snyfer (snyfer) 2008-06-25 02:26:38 Hello and thank you sorry, that I have to reopen: this is not fully true: "The reason for this is that the monitor-join option has been removed from app_queue in favor of using MixMonitor for mixing files." yes and this is working great! BUT: 1. mixmonitor mixes in and outchannel together in one monofile. Many people (in fact every one who does record interviews) needs a stereo file with in channel at e.g. left and out channel at right stereo channel! 2. when you need to start any executable after a queue call e.g. to add some data to a db you can not use monitor anymore because there monitor_exec does not work anymore. So you would have to use mixmonitor and loose your _in and _out files So, at least the option to call monitor_exec when monitor_type = monitor has to be reinstalled! the monitor_join is not needed anymore! 3. when you want people to not use soxmix etc. to make stereo files, you would have to impliment a option in mixmonitor to save in and out files to different channels of a stereo file being recorded! 4. monitor_exec is needed at each scenary for example to convert to mp3 files! Hope you understand the problem of the lost monitor_exec and can reinstall this. Thank you very much.    best regards Martin By: snyfer (snyfer) 2008-06-26 01:20:23 last note was not send to buglist - added again: Hello and thank you sorry, that I have to reopen: this is not fully true: "The reason for this is that the monitor-join option has been removed from app_queue in favor of using MixMonitor for mixing files." yes and this is working great! BUT: 1. mixmonitor mixes in and outchannel together in one monofile. Many people (in fact every one who does record interviews) needs a stereo file with in channel at e.g. left and out channel at right stereo channel! 2. when you need to start any executable after a queue call e.g. to add some data to a db you can not use monitor anymore because there monitor_exec does not work anymore. So you would have to use mixmonitor and loose your _in and _out files So, at least the option to call monitor_exec when monitor_type = monitor has to be reinstalled! the monitor_join is not needed anymore! 3. when you want people to not use soxmix etc. to make stereo files, you would have to impliment a option in mixmonitor to save in and out files to different channels of a stereo file being recorded! 4. monitor_exec is needed at each scenary for example to convert to mp3 files! Hope you understand the problem of the lost monitor_exec and can reinstall this. Thank you very much.    best regards Martin By: Digium Subversion (svnbot) 2008-06-26 19:08:41 Repository: asterisk Revision: 125649 U   trunk/apps/app_queue.c ------------------------------------------------------------------------ r125649 | mmichelson | 2008-06-26 19:08:38 -0500 (Thu, 26 Jun 2008) | 15 lines The monitor-join option for queues was deprecated in favor of using MixMonitor to mix audio. However, it was pointed out to me that because of this, the command set for the MONITOR_EXEC variable is ignored as well. This means that people can't do their own custom mixing commands at the end of recordings in order to make, for instance, stereo recordings of calls. With this patch, app_queue will set the "joinfiles" variable for the channel's monitor if MONITOR_EXEC is not zero-length. This means that for normal audio mixing, MixMonitor is still the preferred choice, but we allow custom mixing to be done with the two Monitor streams if desired. (closes issue ASTERISK-12254) Reported by: snyfer ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125649