Summary:	ASTERISK-12232: [patch] IMAP forwarding does not go to the correct mailbox.
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2008-06-19 09:22:30	Date Closed:	2008-06-19 15:26:05
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) destination_forward.patch
Description:	Forwarded messages are not stored in the correct IMAP mailbox.  The check for the destination mailbox vm_state may fail (if that mailbox has never been accessed) so an additional mailbox vm_state search (by user) is run to ensure that a proper vm_state is available. ****** ADDITIONAL INFORMATION ****** There is a piece of a previous patch in this patch (right below the code that was added) - the line: STORE(todir, vmtmp->mailbox, vmtmp->context, vms->curmsg, chan, vmtmp, fmt, duration, dstvms, tmptxtfile, urgent_str); Can that line be removed from the patch without messing up the patch?  Otherwise I will have to back out other patches to create this one.
Comments:	By: Mark Michelson (mmichelson) 2008-06-19 13:13:38 Yes, it shouldn't be a problem to remove that one line from the patch. The only problem I have with this patch is a minor one, and that is the name of the function get_vm_state_by_user(). It's really a nitpick, but there are similarly named functions (e.g. get_vm_state_by_imap_user and get_vm_state_by_mailbox) which retrieve a vm_state from the vmstates list. This new function actually allocates a new vm_state based on information from the vm_user struct. As such, I would probably call it create_vm_state_from_user or something similar. An interesting janitor project would be to use that function for all dynamic allocation of vm_state structures, but that's for a different time. Anyway, coding-wise, this patch is fine. I'll get it merged with the function name changed to something different. Thanks for the bug fix! By: Digium Subversion (svnbot) 2008-06-19 15:21:51 Repository: asterisk Revision: 124112 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r124112 | mmichelson | 2008-06-19 15:21:49 -0500 (Thu, 19 Jun 2008) | 8 lines Fix IMAP forwarding so that messages are sent to the proper mailbox. (closes issue ASTERISK-12232) Reported by: jaroth Patches:      destination_forward.patch uploaded by jaroth (license 50) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=124112 By: Digium Subversion (svnbot) 2008-06-19 15:23:48 Repository: asterisk Revision: 124121 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r124121 | mmichelson | 2008-06-19 15:23:46 -0500 (Thu, 19 Jun 2008) | 16 lines Merged revisions 124112 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines Fix IMAP forwarding so that messages are sent to the proper mailbox. (closes issue ASTERISK-12232) Reported by: jaroth Patches:      destination_forward.patch uploaded by jaroth (license 50) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=124121 By: Digium Subversion (svnbot) 2008-06-19 15:26:05 Repository: asterisk Revision: 124124 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_voicemail.c ------------------------------------------------------------------------ r124124 | mmichelson | 2008-06-19 15:26:02 -0500 (Thu, 19 Jun 2008) | 24 lines Merged revisions 124121 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r124121 | mmichelson | 2008-06-19 15:30:23 -0500 (Thu, 19 Jun 2008) | 16 lines Merged revisions 124112 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines Fix IMAP forwarding so that messages are sent to the proper mailbox. (closes issue ASTERISK-12232) Reported by: jaroth Patches:      destination_forward.patch uploaded by jaroth (license 50) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=124124