Summary:	ASTERISK-12228: [patch] "Your message has been saved" played twice.
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2008-06-19 09:04:18	Date Closed:	2008-06-26 16:00:13
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) duplicate_saved.patch
Description:	When saving a comment to be attached to a forwarded message (using IMAP storage), the user currently hears "Your message has been saved" twice (once for the comment and once for the forwarded message).  This patch fixes the issue.
Comments:	By: Tilghman Lesher (tilghman) 2008-06-19 10:35:56 Unfortunately, this code does not work when NOT using IMAP storage. By: James Rothenberger (jaroth) 2008-06-19 10:41:36 In the case of standard file-based storage, wouldn't tmptxtfile remain unset since it is only used in IMAP, and the check would evaluate to true?  If it evaluates to true, then the message is played just as it is currently (which is always). By: Digium Subversion (svnbot) 2008-06-26 12:33:24 Repository: asterisk Revision: 125438 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r125438 | tilghman | 2008-06-26 12:33:16 -0500 (Thu, 26 Jun 2008) | 6 lines Don't play "your message has been saved" twice. (closes issue ASTERISK-12228) Reported by: jaroth Patches:       duplicate_saved.patch uploaded by jaroth (license 50) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125438 By: Digium Subversion (svnbot) 2008-06-26 12:35:15 Repository: asterisk Revision: 125439 _U  branches/1.6.0/ ------------------------------------------------------------------------ r125439 | tilghman | 2008-06-26 12:35:12 -0500 (Thu, 26 Jun 2008) | 13 lines Blocked revisions 125438 via svnmerge ........ r125438 | tilghman | 2008-06-26 12:40:25 -0500 (Thu, 26 Jun 2008) | 6 lines Don't play "your message has been saved" twice. (closes issue ASTERISK-12228) Reported by: jaroth Patches:       duplicate_saved.patch uploaded by jaroth (license 50) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125439 By: Digium Subversion (svnbot) 2008-06-26 16:00:13 Repository: asterisk Revision: 125479 _U  team/seanbright/resolve-shadow-warnings/ U   team/seanbright/resolve-shadow-warnings/apps/app_queue.c ------------------------------------------------------------------------ r125479 | seanbright | 2008-06-26 15:59:57 -0500 (Thu, 26 Jun 2008) | 84 lines Merged revisions 125332-125333,125385-125386,125438,125477 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r125332 | russell | 2008-06-26 11:37:01 -0400 (Thu, 26 Jun 2008) | 5 lines - add get_max_rate timing API call - change ast_settimeout() to honor max rate in edge cases of file playback  (this will make some warning messages go away at the end of playing back   a file) ................ r125333 | kpfleming | 2008-06-26 11:50:07 -0400 (Thu, 26 Jun 2008) | 13 lines Merged revisions 125327 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125327 | kpfleming | 2008-06-26 10:30:33 -0500 (Thu, 26 Jun 2008) | 5 lines ensure that (whenever possible) if we generate a log message because an ioctl() call to DAHDI/Zaptel failed, that we include the reason it failed by including the stringified error number (issue AST-80) ........ ................ r125385 | oej | 2008-06-26 12:54:22 -0400 (Thu, 26 Jun 2008) | 12 lines Merged revisions 125384 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125384 | oej | 2008-06-26 18:32:08 +0200 (Tor, 26 Jun 2008) | 3 lines Add support for peer realm based auth (a few missing lines, the rest is well documented but never worked) ........ ................ r125386 | tilghman | 2008-06-26 13:06:17 -0400 (Thu, 26 Jun 2008) | 6 lines Convert casts to unions, to fix alignment issues on Solaris (closes issue ASTERISK-12263) Reported by: snuffy Patches:       bug_12932_20080627.diff uploaded by snuffy (license 35) ................ r125438 | tilghman | 2008-06-26 13:40:25 -0400 (Thu, 26 Jun 2008) | 6 lines Don't play "your message has been saved" twice. (closes issue ASTERISK-12228) Reported by: jaroth Patches:       duplicate_saved.patch uploaded by jaroth (license 50) ................ r125477 | mmichelson | 2008-06-26 16:57:41 -0400 (Thu, 26 Jun 2008) | 19 lines Merged revisions 125476 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125476 | mmichelson | 2008-06-26 15:56:01 -0500 (Thu, 26 Jun 2008) | 11 lines Prior to this patch, the "queue show" command used cached information for realtime queues instead of giving up-to-date info. Now realtime is queried for the latest and greatest in queue info. (closes issue ASTERISK-12195) Reported by: bcnit Patches:      queue_show.patch uploaded by putnopvut (license 60) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125479