[Home]

Summary:ASTERISK-12227: [patch] Fix comparison logic to determine urgent versus non-urgent.
Reporter:James Rothenberger (jaroth)Labels:
Date Opened:2008-06-19 08:59:32Date Closed:2008-07-02 15:45:15
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) mark_urgent.patch
Description:Messages in IMAP storage were not being marked or checked properly due to strcmp comparisons.  This patch fixes the issue.
Comments:By: James Rothenberger (jaroth) 2008-06-19 09:28:02

First patch file was incorrect.  Please use mark_urgent.patch
By: Tilghman Lesher (tilghman) 2008-06-19 10:16:28

This patch isn't right, either.  Basically, you're saying that if the flag is missing, the message is urgent.
By: James Rothenberger (jaroth) 2008-06-19 10:23:07

Hmmmm, the idea is that if the flag is not set, or if it is not set to "Urgent", then set it to Urgent (toggle).  That is what this line does:

if (ast_strlen_zero(flag) || (!ast_strlen_zero(flag) && strcmp(flag, "Urgent"))) {

This check is done only when toggling between urgent/nonurgent by pressing "4".
By: Digium Subversion (svnbot) 2008-07-02 15:45:12

Repository: asterisk
Revision: 127564

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r127564 | tilghman | 2008-07-02 15:45:10 -0500 (Wed, 02 Jul 2008) | 5 lines

Fix some crashlike bugs because flag could be NULL in play_record_review().
(Closes issue ASTERISK-12227)
Reported by: jaroth
Patch originally by jaroth, fixed by me.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=127564