[Home]

Summary:ASTERISK-12225: notifyringing option comment in configs/sip.conf.sample
Reporter:Gaetan Minet (gminet)Labels:
Date Opened:2008-06-19 07:50:01Date Closed:2008-06-19 11:15:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I _think_ the comment in sip.conf.sample regarding the notifyringing option (and the option name itself, but that's another story) are quite misleading.
Based on the original patch that implemented that option and on my reading of the source code, this option doesn't control the whole ringing state notification as suggested. The ringing ("early" ) notification is always sent regardless the actual value of the option.

Instead it controls whether a second RINGING channel on a already INUSE hint should be notified as INUSE ("confirmed") or RINGING ("early").



****** ADDITIONAL INFORMATION ******

See original implementation in bug id 0003882

I was just trying to disable BLF on ringing on thomson ST230 phones as this seems to generate noise during a conversation.

The option also changes a "minor" thing in the notify message in dialog_info+xml, is this normal ?

With notifyringing set to no:

<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="20" state="full" entity="sip:1102@192.168.71.240:5060">
<dialog id="1102">
<state>early</state>
</dialog>
</dialog-info>

With notifyringing set to yes:

<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="22" state="full" entity="sip:1102@192.168.71.240:5060">
<dialog id="1102" direction="recipient">
<state>early</state>
</dialog>
</dialog-info>
Comments:By: Digium Subversion (svnbot) 2008-06-19 11:13:47

Repository: asterisk
Revision: 123883

U   branches/1.4/configs/sip.conf.sample

------------------------------------------------------------------------
r123883 | tilghman | 2008-06-19 11:13:47 -0500 (Thu, 19 Jun 2008) | 4 lines

Correct description of notifyringing option.
(Closes issue ASTERISK-12225)
Reported by gminet

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123883
By: Digium Subversion (svnbot) 2008-06-19 11:14:31

Repository: asterisk
Revision: 123887

_U  trunk/
U   trunk/configs/sip.conf.sample

------------------------------------------------------------------------
r123887 | tilghman | 2008-06-19 11:14:30 -0500 (Thu, 19 Jun 2008) | 12 lines

Merged revisions 123883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123883 | tilghman | 2008-06-19 11:20:41 -0500 (Thu, 19 Jun 2008) | 4 lines

Correct description of notifyringing option.
(Closes issue ASTERISK-12225)
Reported by gminet

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123887
By: Digium Subversion (svnbot) 2008-06-19 11:15:11

Repository: asterisk
Revision: 123891

_U  branches/1.6.0/
U   branches/1.6.0/configs/sip.conf.sample

------------------------------------------------------------------------
r123891 | tilghman | 2008-06-19 11:15:11 -0500 (Thu, 19 Jun 2008) | 20 lines

Merged revisions 123887 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r123887 | tilghman | 2008-06-19 11:21:32 -0500 (Thu, 19 Jun 2008) | 12 lines

Merged revisions 123883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123883 | tilghman | 2008-06-19 11:20:41 -0500 (Thu, 19 Jun 2008) | 4 lines

Correct description of notifyringing option.
(Closes issue ASTERISK-12225)
Reported by gminet

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123891