Summary:ASTERISK-12210: [patch] small bug introduced with fix for 12656
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2008-06-17 06:51:44Date Closed:2008-08-15 09:58:35
Versions:Frequency of
Environment:Attachments:( 0) v1-12874.patch
Description:It looks like I've made a typo in my patch for 12656 so it is always "f" frame which gets dupped and queued. However for the case of hangup, it should be hangup frame.

Although I was not hit by any problems, I decided to fix the code. Attached patch contains the fix. It also re-organizes condition checks just a little bit to make code easier to read and to have single "cleanup path".


WARNING!!! I have NOT tested this patch - only read it several times and made sure it applies well and Asterisk builds.
I haven't tested it because 1.4 branch is being moved from Zap to DAHDI and I do not want to have update my dialplans and config on production system.
Comments:By: Jason Parker (jparker) 2008-06-17 11:13:18

1.4 still supports Zaptel, and will continue to do so.

You shouldn't need to update any configs for it.

By: Russell Bryant (russell) 2008-08-15 09:56:18

The patch looks good.  I'll commit it in a few minutes.

By: Digium Subversion (svnbot) 2008-08-15 09:58:33

Repository: asterisk
Revision: 138027

U   branches/1.4/main/autoservice.c

r138027 | russell | 2008-08-15 09:58:32 -0500 (Fri, 15 Aug 2008) | 9 lines

Ensure that when a hangup occurs in autoservice, that a hangup frame gets
properly deferred to be read from the channel owner when it gets taken out
of autoservice.

(closes issue ASTERISK-12210)
Reported by: dimas
     v1-12874.patch uploaded by dimas (license 88)