Summary: | ASTERISK-12189: agents.conf: ackcall=always is not documented | ||
Reporter: | David Woolley (davidw) | Labels: | |
Date Opened: | 2008-06-13 10:22:14 | Date Closed: | 2008-06-25 20:19:29 |
Priority: | Trivial | Regression? | No |
Status: | Closed/Complete | Components: | Documentation |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | chan_agent recognizes a value of "always" for ackall, both in the configuration file sample and as a value of ${AGENTACKALL}, but I can find no documentation as to what it actually means. ****** ADDITIONAL INFORMATION ****** ASTERISK-167 mentions this parameter as already existing in 2003. It also refers to the use of AgentLogin, whereas the current description implies ackcall only works for call backs. | ||
Comments: | By: David Woolley (davidw) 2008-06-13 10:23:56 For the benefit of search engines, that should have been ackcall=always. By: David Woolley (davidw) 2008-06-13 10:46:42 Empirically, it looks like it enables ackcall processing for AgentLogin as well as for AgentCallbackLogin, but the remaining issue is is it undocumented because it is somehow broken, or is it simply undocumented. (I'm a little worried that the agent isn't being marked busy until the call is accepted, but I'll follow that up if it supposed to work.) [Jun 13 16:41:28] VERBOSE[27350] logger.c: -- Stopped music on hold on SIP/4 222-0a0fb0c0 [Jun 13 16:41:28] VERBOSE[27350] logger.c: -- agent_call, call to agent '100 1' call on 'SIP/4222-0a0fb0c0' [Jun 13 16:41:28] VERBOSE[27350] logger.c: -- <SIP/4222-0a0fb0c0> Playing 'beep' (language 'en') [Jun 13 16:41:29] VERBOSE[27350] logger.c: -- Called Agent/1001 [Jun 13 16:41:29] DEBUG[27350] chan_agent.c: Bridge on 'SIP/4222-0a0fb0c0' being set to 'Agent/1001' (3) [Jun 13 16:41:33] VERBOSE[27350] logger.c: -- SIP/4222-0a0fb0c0 acknowledged [Jun 13 16:41:33] VERBOSE[27350] logger.c: -- Agent/1001 answered Local/XXXX By: Mark Michelson (mmichelson) 2008-06-13 14:16:58 I believe that you actually answered your own question in the additional information section. I looked at the code and couldn't make heads or tails of it. Then I ran some tests to see what the difference is. Here's what I found: callback agents had to press '#' to acknowledge the call with ackcall set to "yes" or "always." The AgentLogin-type agents only had to press '#' to acknowledge the call if ackcall was set to "always." I believe that is the difference between the two. I will add documentation to clarify this. Edit: Sorry I didn't refresh the page to see your second note... By: Digium Subversion (svnbot) 2008-06-25 20:17:14 Repository: asterisk Revision: 125218 U branches/1.4/configs/agents.conf.sample ------------------------------------------------------------------------ r125218 | tilghman | 2008-06-25 20:17:14 -0500 (Wed, 25 Jun 2008) | 4 lines Document ackcall=always. (closes issue ASTERISK-12189) Reported by: davidw ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125218 By: Digium Subversion (svnbot) 2008-06-25 20:18:12 Repository: asterisk Revision: 125223 _U trunk/ U trunk/configs/agents.conf.sample ------------------------------------------------------------------------ r125223 | tilghman | 2008-06-25 20:18:12 -0500 (Wed, 25 Jun 2008) | 12 lines Merged revisions 125218 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125218 | tilghman | 2008-06-25 20:24:26 -0500 (Wed, 25 Jun 2008) | 4 lines Document ackcall=always. (closes issue ASTERISK-12189) Reported by: davidw ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125223 By: Digium Subversion (svnbot) 2008-06-25 20:19:29 Repository: asterisk Revision: 125228 _U branches/1.6.0/ U branches/1.6.0/configs/agents.conf.sample ------------------------------------------------------------------------ r125228 | tilghman | 2008-06-25 20:19:26 -0500 (Wed, 25 Jun 2008) | 20 lines Merged revisions 125223 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r125223 | tilghman | 2008-06-25 20:25:16 -0500 (Wed, 25 Jun 2008) | 12 lines Merged revisions 125218 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125218 | tilghman | 2008-06-25 20:24:26 -0500 (Wed, 25 Jun 2008) | 4 lines Document ackcall=always. (closes issue ASTERISK-12189) Reported by: davidw ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=125228 |