[Home]

Summary:ASTERISK-12154: [patch] one way only audio in MS-Office 2007 to asterisk calls
Reporter:andrea lanza (lanzaandrea)Labels:
Date Opened:2008-06-06 08:24:14Date Closed:2008-06-16 13:25:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.c.diff
( 1) full.fromasterisktoocs
( 2) full.fromocstoasterisk
( 3) patch2_per_utf-8.txt
( 4) patch_per_utf-8.txt
Description:When connectin an asterisk server 1.6.0beta8 to an MS Office Communication server 2007 Mediation server role, you can place bidirectiona audio calls when calling from an asterisk to a MS ocs client
doing the oppsite, asterisk phone speak and the ms ocs client listen, but not the opposite.
The problem is the presence of a sip header
application/sdp; charset=utf-8
sent by MS OCS unknown and unhandled by chan_sip

Comments:By: Russell Bryant (russell) 2008-06-06 08:26:28

Code must be included as an attachment, instead of the summary of the bug report.  Thanks!
By: Russell Bryant (russell) 2008-06-06 08:27:09

Can you please attach a SIP debug trace of the problematic call?
By: andrea lanza (lanzaandrea) 2008-06-06 08:32:48

Yes, of course I could !
I am adding two files, called
full.fromocstoasterisk
full.fromasterisktoocs
before taking these files I did
core set verbose 9
core set debug 9
sip set debug on

these log files were obtained WITHOUT the patch I post
By: Brett Bryant (bbryant) 2008-06-06 09:41:34

lanzaandrea, you'll need to go submit a contribution license at the top of this page and then resubmit your patch before we'll be able to look at it.
By: andrea lanza (lanzaandrea) 2008-06-06 09:45:14

I signed the license.
By: Brett Bryant (bbryant) 2008-06-06 09:59:05

lanzaandrea, you will have to resubmit your patch.
By: andrea lanza (lanzaandrea) 2008-06-06 11:03:50

I don't understand what to do.
If I resubmit, I get a duplicate file error.

Anyway I asked somebody else who merged the code
with a patch better than mine, and now is available via svn
By: andrea lanza (lanzaandrea) 2008-06-10 05:53:46

What have I to do with that "License PENDING" state on the
2nd patch I uploaded after signig the license ?
Is it something depending on my side I didn't do ?
By: Donny Kavanagh (donnyk) 2008-06-10 14:09:08

Your license is fine now.
By: andrea lanza (lanzaandrea) 2008-06-10 14:10:05

Thanks
By: Ronald Chan (loloski) 2008-06-11 12:11:49

lanzaandrea,

Can you post your patch in the form of svn diff ?, so that * developer can take a look at your patch or pick this up?


Thanks
By: andrea lanza (lanzaandrea) 2008-06-12 02:39:02

I  am postig again my patch using this syntax:

diff -ubB chan_sip.original.1.6.0-beta9.c chan_sip.c

If anything different is needed, please tell me.

The new diff patch I am posting is in comparison with 1.6.0-beta9, having
the same issue.
By: Digium Subversion (svnbot) 2008-06-16 07:24:11

Repository: asterisk
Revision: 122919

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r122919 | file | 2008-06-16 07:24:10 -0500 (Mon, 16 Jun 2008) | 6 lines

Only compare the first 15 characters so that even if the charset is specified we still accept it as SDP.
(closes issue ASTERISK-12154)
Reported by: lanzaandrea
Patches:
     chan_sip.c.diff uploaded by lanzaandrea (license 496)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=122919
By: Digium Subversion (svnbot) 2008-06-16 07:25:21

Repository: asterisk
Revision: 122920

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r122920 | file | 2008-06-16 07:25:20 -0500 (Mon, 16 Jun 2008) | 14 lines

Merged revisions 122919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122919 | file | 2008-06-16 09:31:09 -0300 (Mon, 16 Jun 2008) | 6 lines

Only compare the first 15 characters so that even if the charset is specified we still accept it as SDP.
(closes issue ASTERISK-12154)
Reported by: lanzaandrea
Patches:
     chan_sip.c.diff uploaded by lanzaandrea (license 496)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=122920
By: Digium Subversion (svnbot) 2008-06-16 07:25:58

Repository: asterisk
Revision: 122921

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r122921 | file | 2008-06-16 07:25:57 -0500 (Mon, 16 Jun 2008) | 22 lines

Merged revisions 122920 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r122920 | file | 2008-06-16 09:32:02 -0300 (Mon, 16 Jun 2008) | 14 lines

Merged revisions 122919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122919 | file | 2008-06-16 09:31:09 -0300 (Mon, 16 Jun 2008) | 6 lines

Only compare the first 15 characters so that even if the charset is specified we still accept it as SDP.
(closes issue ASTERISK-12154)
Reported by: lanzaandrea
Patches:
     chan_sip.c.diff uploaded by lanzaandrea (license 496)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=122921
By: Digium Subversion (svnbot) 2008-06-16 13:25:11

Repository: asterisk
Revision: 123107

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/UPGRADE.txt
A   team/seanbright/resolve-shadow-warnings/apps/app_fax.c
U   team/seanbright/resolve-shadow-warnings/cdr/cdr_tds.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_iax2.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_sip.c
U   team/seanbright/resolve-shadow-warnings/configs/modules.conf.sample
U   team/seanbright/resolve-shadow-warnings/funcs/func_channel.c
U   team/seanbright/resolve-shadow-warnings/include/asterisk/_private.h
U   team/seanbright/resolve-shadow-warnings/include/asterisk/config.h
U   team/seanbright/resolve-shadow-warnings/include/asterisk/timing.h
U   team/seanbright/resolve-shadow-warnings/main/asterisk.c
U   team/seanbright/resolve-shadow-warnings/main/channel.c
U   team/seanbright/resolve-shadow-warnings/main/timing.c
A   team/seanbright/resolve-shadow-warnings/res/res_timing_pthread.c

------------------------------------------------------------------------
r123107 | seanbright | 2008-06-16 13:25:06 -0500 (Mon, 16 Jun 2008) | 109 lines

Merged revisions 122766,122802,122834,122870,122920,122923,122926,122928,122977,123009,123041,123044,123076 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r122766 | tilghman | 2008-06-13 18:52:20 -0400 (Fri, 13 Jun 2008) | 2 lines

Document the input for ast_realtime_require_field()

................
r122802 | tilghman | 2008-06-15 11:21:16 -0400 (Sun, 15 Jun 2008) | 8 lines

Add some more IAX2-specific information about the channel to the CHANNEL()
function and begin the transition from SIPCHANINFO() to just using CHANNEL().
(closes issue ASTERISK-12193)
Reported by: mostyn
Patches:
      iax_and_sip_channel_info.patch uploaded by mostyn (license 398)
      (with some additional cleanup by me)

................
r122834 | seanbright | 2008-06-15 23:33:03 -0400 (Sun, 15 Jun 2008) | 1 line

Resurrected app_fax
................
r122870 | file | 2008-06-16 08:09:54 -0400 (Mon, 16 Jun 2008) | 14 lines

Merged revisions 122869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122869 | file | 2008-06-16 09:08:28 -0300 (Mon, 16 Jun 2008) | 6 lines

Don't send a BYE on a dialog that is already gone during a REFER.
(closes issue ASTERISK-12201)
Reported by: flefoll
Patches:
     chan_sip.c.br14.121495.patch-ALREADYGONE uploaded by flefoll (license 244)

........

................
r122920 | file | 2008-06-16 08:32:02 -0400 (Mon, 16 Jun 2008) | 14 lines

Merged revisions 122919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122919 | file | 2008-06-16 09:31:09 -0300 (Mon, 16 Jun 2008) | 6 lines

Only compare the first 15 characters so that even if the charset is specified we still accept it as SDP.
(closes issue ASTERISK-12154)
Reported by: lanzaandrea
Patches:
     chan_sip.c.diff uploaded by lanzaandrea (license 496)

........

................
r122923 | russell | 2008-06-16 08:48:11 -0400 (Mon, 16 Jun 2008) | 5 lines

- Fix a typo in a timing API call
- Convert the last part of channel.c over to use the timing API.  This would
  not have made a difference when using the dahdi timing module.  I noticed
  it when trying to use another timing source.  Oops.  :)

................
r122926 | russell | 2008-06-16 09:03:40 -0400 (Mon, 16 Jun 2008) | 4 lines

Add a "timing test" CLI command.  It opens a timer and configures it for
50 ticks per second, and then counts to see how many ticks it actually
gets in a second.

................
r122928 | russell | 2008-06-16 09:08:13 -0400 (Mon, 16 Jun 2008) | 11 lines

Merge res_timing_pthread.  This is a timing interface for Asterisk that
does not require DAHDI.  It's called "pthread" because it uses a pthread
API call in the timing thread for sleeping and ensuring we wake up at
an appropriate time.  I wasn't sure what else to call it.  :)

The timing API requires a file descriptor that can be polled on.  So,
when you open a timer, this module creates a pipe and returns the read
end of the pipe.  There is a background thread that wakes up every 10ms
and checks to see if any of the currently open timers need a 'tick' and
writes to the appropriate pipe.

................
r122977 | russell | 2008-06-16 09:31:36 -0400 (Mon, 16 Jun 2008) | 2 lines

Note that only one timing interface should get loaded.

................
r123009 | seanbright | 2008-06-16 11:25:03 -0400 (Mon, 16 Jun 2008) | 1 line

Coding guidelines stuff only.
................
r123041 | seanbright | 2008-06-16 12:29:18 -0400 (Mon, 16 Jun 2008) | 1 line

Remove some unused variables
................
r123044 | seanbright | 2008-06-16 13:14:11 -0400 (Mon, 16 Jun 2008) | 1 line

Convert to use stringfields.  Still some more work to do on config load/reload.
................
r123076 | seanbright | 2008-06-16 13:33:10 -0400 (Mon, 16 Jun 2008) | 1 line

Last commit for a bit, minor cleanups and move the lock initialization.
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123107