[Home]

Summary:ASTERISK-12137: [patch] Using AddQueueMember with the membername parameter causes minor issues
Reporter:David Van Ginneken (davevg)Labels:
Date Opened:2008-06-04 08:55:52Date Closed:2008-06-26 17:45:35
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.diff
Description:If you pass the membername to the AddQueueMember application it does not expose the interface name to the CLI to allow you to manually log off the agent.  Tab completion on the interface returns the membername not the interface which does not allow the removal.  
"queue remove member <tab>" in the example below gives:

asterisk*CLI> queue remove member Test from rrmemory
Unable to remove interface 'Test' from queue 'rrmemory': Not there

Trying to remove it by the member name results in this:
asterisk*CLI> queue remove member "Test User" from rrmemory
Unable to remove interface 'Test User' from queue 'rrmemory': Not there

But if you know the interface ahead of time, you can do (But the tab completion does not show the Local channel):
asterisk*CLI> queue remove member Local/1223@queue-agents/n from rrmemory
Removed interface 'Local/1223@queue-agents/n' from queue 'rrmemory'




****** ADDITIONAL INFORMATION ******

Sample missing the member name:

exten => login,n,AddQueueMember(rrmemory,Local/1223@queue-agents/n,,,)


rrmemory     has 0 calls (max unlimited) in 'rrmemory' strategy (0s holdtime), W:0, C:0, A:0, SL:0.0% within 0s
  Members: >
     Local/1223@queue-agents/n (dynamic) (Not in use) has taken no calls yet
  No Callers

Sample with the member name included.

exten => login,n,AddQueueMember(rrmemory,Local/1223@queue-agents/n,,,Test Agent)


rrmemory     has 0 calls (max unlimited) in 'rrmemory' strategy (0s holdtime), W:0, C:0, A:0, SL:0.0% within 0s
  Members:
     Test Agent (dynamic) (Not in use) has taken no calls yet
  No Callers
Comments:By: Digium Subversion (svnbot) 2008-06-04 09:04:35

Repository: asterisk
Revision: 120285

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r120285 | mmichelson | 2008-06-04 09:04:34 -0500 (Wed, 04 Jun 2008) | 7 lines

Tab completion when removing a member should give the member's interface,
not the name, since the interface is what is expected for the command.

(closes issue ASTERISK-12137)
Reported by: davevg


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=120285
By: Digium Subversion (svnbot) 2008-06-04 09:06:18

Repository: asterisk
Revision: 120286

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r120286 | mmichelson | 2008-06-04 09:06:18 -0500 (Wed, 04 Jun 2008) | 15 lines

Merged revisions 120285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120285 | mmichelson | 2008-06-04 09:11:12 -0500 (Wed, 04 Jun 2008) | 7 lines

Tab completion when removing a member should give the member's interface,
not the name, since the interface is what is expected for the command.

(closes issue ASTERISK-12137)
Reported by: davevg


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=120286
By: Digium Subversion (svnbot) 2008-06-04 09:06:55

Repository: asterisk
Revision: 120287

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_queue.c

------------------------------------------------------------------------
r120287 | mmichelson | 2008-06-04 09:06:54 -0500 (Wed, 04 Jun 2008) | 23 lines

Merged revisions 120286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r120286 | mmichelson | 2008-06-04 09:12:45 -0500 (Wed, 04 Jun 2008) | 15 lines

Merged revisions 120285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120285 | mmichelson | 2008-06-04 09:11:12 -0500 (Wed, 04 Jun 2008) | 7 lines

Tab completion when removing a member should give the member's interface,
not the name, since the interface is what is expected for the command.

(closes issue ASTERISK-12137)
Reported by: davevg


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=120287
By: David Van Ginneken (davevg) 2008-06-04 09:23:29

Patch attached for 2nd part
By: Atis Lezdins (atis) 2008-06-04 10:16:35

The second patch will definitely make output of "queue show" longer than 80 chars, which is currently defined for max_buf.

Additionally I think membername and interface should be somehow separated, as membername is allowed to contain spaces. I propose the following:

22901        has 0 calls (max unlimited) in 'custom' strategy (0s holdtime), W:5, C:0, A:0, SL:0.0% within 0s
  Members:
     Agent/21168 on Local/21168@default_queue with penalty 5 (realtime) (Not in use) has taken 3 calls (last call was 176226 secs ago)

where

Agent/21168 is membername and
Local/21168@default_queue is interface
By: David Van Ginneken (davevg) 2008-06-04 12:14:15

Good point about the limit.  I was thinking we may want a "concise" command for those parsing the values.  But that is not likely to go into the 1.4 branch.  But we'd probably want ~something~ in 1.4 to allow them to get the interface name attached to a membername.
By: Digium Subversion (svnbot) 2008-06-26 17:45:33

Repository: asterisk
Revision: 125585

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r125585 | mmichelson | 2008-06-26 17:45:32 -0500 (Thu, 26 Jun 2008) | 11 lines

Add the interface of a queue member to the output of the "queue show" command
so that it can easily be associated with a queue member's name. This helps
so that the appropriate queue member can be removed or paused since the
interface is required, not the member's name.

(closes issue ASTERISK-12137)
Reported by: davevg
Patches:
     app_queue.diff uploaded by davevg (license 209) with small mod from me


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=125585