[Home]

Summary:ASTERISK-12099: [patch] OOH323 channel names shouldn't use CIDname
Reporter:Tony Mountifield (softins)Labels:
Date Opened:2008-05-28 12:26:18Date Closed:2008-05-28 17:25:39
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Addons/chan_ooh323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ooh323-1.4-diff.txt
( 1) ooh323-1.6.0-trunk-diff.txt
Description:For incoming calls, OOH323 channels are currently named using the CIDName of the incoming call (if set), which could be anything completely unrelated to the host from which the call came, and even contain strange chars, e.g.

-- Executing Answer("OOH323/Tony Mountifield-3f83", "1") in new stack

For outgoing calls, the channel uses the name of the peer or friend to which the call is routed. I would have thought for incoming calls, it should use the name of the user or friend section that was matched.

For more details, see my post on -dev at http://lists.digium.com/pipermail/asterisk-dev/2008-May/033101.html

The attached patches cause the name to be generated using the name of the matched section:

-- Executing Answer("OOH323/h323si-420a", "1") in new stack

The patches also correct five places where the output controlled by "ooh323 set debug" was sent to ast_log/ast_debug instead of to ast_verbose.

The patch for 1.4 won't merge to trunk or 1.6.0, so a separate patch has been included for 1.6.0 and trunk.
Comments:By: Digium Subversion (svnbot) 2008-05-28 17:23:03

Repository: asterisk-addons
Revision: 606

U   branches/1.4/channels/chan_ooh323.c

------------------------------------------------------------------------
r606 | tilghman | 2008-05-28 17:23:02 -0500 (Wed, 28 May 2008) | 7 lines

Change channel name to use the section name, rather than CallerID name (which
can contain strange characters).
(closes issue ASTERISK-12099)
Reported by: softins
Patches:
      ooh323-1.4-diff.txt uploaded by softins (license 197)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=606
By: Digium Subversion (svnbot) 2008-05-28 17:24:55

Repository: asterisk-addons
Revision: 607

_U  trunk/
U   trunk/channels/chan_ooh323.c

------------------------------------------------------------------------
r607 | tilghman | 2008-05-28 17:24:54 -0500 (Wed, 28 May 2008) | 15 lines

Merged revisions 606 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/branches/1.4

........
r606 | tilghman | 2008-05-28 17:29:27 -0500 (Wed, 28 May 2008) | 7 lines

Change channel name to use the section name, rather than CallerID name (which
can contain strange characters).
(closes issue ASTERISK-12099)
Reported by: softins
Patches:
      ooh323-1.4-diff.txt uploaded by softins (license 197)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=607
By: Digium Subversion (svnbot) 2008-05-28 17:25:39

Repository: asterisk-addons
Revision: 608

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_ooh323.c

------------------------------------------------------------------------
r608 | tilghman | 2008-05-28 17:25:39 -0500 (Wed, 28 May 2008) | 23 lines

Merged revisions 607 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/trunk

................
r607 | tilghman | 2008-05-28 17:31:22 -0500 (Wed, 28 May 2008) | 15 lines

Merged revisions 606 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/branches/1.4

........
r606 | tilghman | 2008-05-28 17:29:27 -0500 (Wed, 28 May 2008) | 7 lines

Change channel name to use the section name, rather than CallerID name (which
can contain strange characters).
(closes issue ASTERISK-12099)
Reported by: softins
Patches:
      ooh323-1.4-diff.txt uploaded by softins (license 197)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=608