| Summary: | ASTERISK-12088: [patch] Fix for vasprintf with printf format warning solaris | ||
| Reporter: | snuffy (snuffy) | Labels: | |
| Date Opened: | 2008-05-27 10:22:43 | Date Closed: | 2008-05-27 14:21:58 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/Portability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) bug_12729.diff | |
| Description: | Was having issues compiling latest trunk with new compile flags. Required this for compliation to be successful. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2008-05-27 10:55:59 Shouldn't that be: format (printf, 2, 3) ? By: snuffy (snuffy) 2008-05-27 11:32:03 2,3 does not work since its a 'valist' as third arguement not a '...' You'll get this error. /ast-trunk/include/asterisk/compat.h:113: error: args to be formatted is not '...' gmake[1]: *** [eagi-test.o] Error 1 I came to using that by looking at examples i could find on the web, aka using what is included in the patch is the only way it compiles correctly without error. By: Russell Bryant (russell) 2008-05-27 14:20:11 2,0 is right ... it just says to check the format string for validity. It won't be able to check to see if the arguments are correct. By: Digium Subversion (svnbot) 2008-05-27 14:21:30 Repository: asterisk Revision: 118556 U trunk/include/asterisk/compat.h ------------------------------------------------------------------------ r118556 | russell | 2008-05-27 14:21:28 -0500 (Tue, 27 May 2008) | 6 lines Add printf format attribute for vasprintf(). (closes issue ASTERISK-12088) Reported by: snuffy Patches: bug_12729.diff uploaded by snuffy (license 35) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118556 By: Digium Subversion (svnbot) 2008-05-27 14:21:58 Repository: asterisk Revision: 118557 _U branches/1.6.0/ U branches/1.6.0/include/asterisk/compat.h ------------------------------------------------------------------------ r118557 | russell | 2008-05-27 14:21:57 -0500 (Tue, 27 May 2008) | 14 lines Merged revisions 118556 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r118556 | russell | 2008-05-27 14:27:48 -0500 (Tue, 27 May 2008) | 6 lines Add printf format attribute for vasprintf(). (closes issue ASTERISK-12088) Reported by: snuffy Patches: bug_12729.diff uploaded by snuffy (license 35) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118557 | ||