[Home]

Summary:ASTERISK-12082: [patch] unterminated string in 1.4 compat mode
Reporter:Atis Lezdins (atis)Labels:
Date Opened:2008-05-26 11:20:11Date Closed:2008-05-27 08:08:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/pbx_realtime
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) pbx_realtime_compat_string.patch
( 1) pbx_realtime_compat_string+expr_v2.patch
( 2) pbx_realtime_compat_string+expr.patch
Description:when using pbx_realtime in 1.4 compat mode all strings readed from database have weird symbols at end. This led me to inspecting code, and seems that "\0" is never added at end.
Comments:By: Atis Lezdins (atis) 2008-05-26 11:44:38

while continuing testing this i found out that compatibility option replaces pipes inside expressions, but it shouldn't as in expressions it means OR. Added patch that solves this.
By: Atis Lezdins (atis) 2008-05-26 13:29:41

A little cleanup.

P.S.
I know that my solution for expression processing is ugly, but i don't see any other easy way for now :)
By: Digium Subversion (svnbot) 2008-05-27 08:07:11

Repository: asterisk
Revision: 118300

U   trunk/pbx/pbx_realtime.c

------------------------------------------------------------------------
r118300 | tilghman | 2008-05-27 08:07:03 -0500 (Tue, 27 May 2008) | 4 lines

In compat14 mode, don't translate pipes inside expressions, as they aren't
argument delimiters, but rather 'or' symbols.
(Closes issue ASTERISK-12082)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118300
By: Digium Subversion (svnbot) 2008-05-27 08:08:24

Repository: asterisk
Revision: 118301

_U  branches/1.6.0/
U   branches/1.6.0/pbx/pbx_realtime.c

------------------------------------------------------------------------
r118301 | tilghman | 2008-05-27 08:08:23 -0500 (Tue, 27 May 2008) | 12 lines

Merged revisions 118300 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r118300 | tilghman | 2008-05-27 08:13:17 -0500 (Tue, 27 May 2008) | 4 lines

In compat14 mode, don't translate pipes inside expressions, as they aren't
argument delimiters, but rather 'or' symbols.
(Closes issue ASTERISK-12082)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118301