Summary: | ASTERISK-12081: [patch] Problems with Restore of fullcontact + ipaddr from RealtimeDB with rtcachefriends | ||
Reporter: | Lorenz Barth (bartpbx) | Labels: | |
Date Opened: | 2008-05-25 10:31:09 | Date Closed: | 2008-05-25 11:14:27 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/DatabaseSupport |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) 20080525__bug12722.diff.txt | |
Description: | A fresh created peer from realtime is missing fullcontact + ipaddr + port is rtcachefriends is active. Also a fullcontact like sip:100081@XX.XXX.XXX.XXX;uniq=8201DB6A1470DB6A08E190DA3094A is note restored correctly | ||
Comments: | By: Lorenz Barth (bartpbx) 2008-05-25 10:47:59 patch from Corydon76 fixes the problem. everything seems to be working as expected By: Digium Subversion (svnbot) 2008-05-25 10:55:53 Repository: asterisk Revision: 118251 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r118251 | tilghman | 2008-05-25 10:55:46 -0500 (Sun, 25 May 2008) | 12 lines Realtime flag affects construction in multiple ways, so consulting whether rtcachefriends was set was done too soon (needed to be done inside build_peer, not just as a flag to build_peer). Also, fullcontact needed to be reconstructed, because realtime separates the embedded ';' into multiple fields. (closes issue ASTERISK-12081) Reported by: barthpbx Patches: 20080525__bug12722.diff.txt uploaded by Corydon76 (license 14) Tested by: barthpbx (Much of the discussion happened on #asterisk-dev for diagnosing this issue) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118251 By: Digium Subversion (svnbot) 2008-05-25 11:11:07 Repository: asterisk Revision: 118252 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r118252 | tilghman | 2008-05-25 11:11:00 -0500 (Sun, 25 May 2008) | 20 lines Merged revisions 118251 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118251 | tilghman | 2008-05-25 11:02:04 -0500 (Sun, 25 May 2008) | 12 lines Realtime flag affects construction in multiple ways, so consulting whether rtcachefriends was set was done too soon (needed to be done inside build_peer, not just as a flag to build_peer). Also, fullcontact needed to be reconstructed, because realtime separates the embedded ';' into multiple fields. (closes issue ASTERISK-12081) Reported by: barthpbx Patches: 20080525__bug12722.diff.txt uploaded by Corydon76 (license 14) Tested by: barthpbx (Much of the discussion happened on #asterisk-dev for diagnosing this issue) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118252 By: Digium Subversion (svnbot) 2008-05-25 11:14:27 Repository: asterisk Revision: 118253 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r118253 | tilghman | 2008-05-25 11:14:26 -0500 (Sun, 25 May 2008) | 28 lines Merged revisions 118252 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r118252 | tilghman | 2008-05-25 11:17:05 -0500 (Sun, 25 May 2008) | 20 lines Merged revisions 118251 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118251 | tilghman | 2008-05-25 11:02:04 -0500 (Sun, 25 May 2008) | 12 lines Realtime flag affects construction in multiple ways, so consulting whether rtcachefriends was set was done too soon (needed to be done inside build_peer, not just as a flag to build_peer). Also, fullcontact needed to be reconstructed, because realtime separates the embedded ';' into multiple fields. (closes issue ASTERISK-12081) Reported by: barthpbx Patches: 20080525__bug12722.diff.txt uploaded by Corydon76 (license 14) Tested by: barthpbx (Much of the discussion happened on #asterisk-dev for diagnosing this issue) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118253 |