Summary:	ASTERISK-12060: [patch] ExternalIVR will never read from a socket
Reporter:	Chris Tooley (ctooley)	Labels:
Date Opened:	2008-05-21 07:58:01	Date Closed:	2008-05-21 08:35:36
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_externalivr
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) fix_externalivr_waitfor_nandfds.diff ( 1) fix_externalivr_waitfor_nandfds-v2.diff ( 2) fix_externalivr_waitfor_nandfds-v3.diff
Description:	ExternalIVR's socket support is prevented from determining that there is something waiting on the socket because ast_waitfor_nandfds is not being called correctly.  This patch checks for the existence of an error file descriptor before telling ast_waitfor_nandfds which one to use.  As there is no error fd on a socket, it will not work.
Comments:	By: Digium Subversion (svnbot) 2008-05-21 08:33:42 Repository: asterisk Revision: 117431 U   trunk/apps/app_externalivr.c ------------------------------------------------------------------------ r117431 | tilghman | 2008-05-21 08:33:33 -0500 (Wed, 21 May 2008) | 6 lines On socket-based connections, there is no error FD, so don't try waiting on one. (closes issue ASTERISK-12060) Reported by: ctooley Patches:       fix_externalivr_waitfor_nandfds-v3.diff uploaded by ctooley (license 136) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=117431 By: Digium Subversion (svnbot) 2008-05-21 08:35:36 Repository: asterisk Revision: 117432 _U  branches/1.6.0/ ------------------------------------------------------------------------ r117432 | tilghman | 2008-05-21 08:35:34 -0500 (Wed, 21 May 2008) | 13 lines Blocked revisions 117431 via svnmerge ........ r117431 | tilghman | 2008-05-21 08:39:41 -0500 (Wed, 21 May 2008) | 6 lines On socket-based connections, there is no error FD, so don't try waiting on one. (closes issue ASTERISK-12060) Reported by: ctooley Patches:       fix_externalivr_waitfor_nandfds-v3.diff uploaded by ctooley (license 136) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=117432