Summary: | ASTERISK-12045: [patch] chan_h323 doesn't compile with pwlib 1.12.0 | ||
Reporter: | Andriy I Pylypenko (bamby) | Labels: | |
Date Opened: | 2008-05-19 05:55:49 | Date Closed: | 2008-05-19 10:21:18 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_h323 |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) pwlib_nopipe.diff | |
Description: | The pwlib library prior 1.12.0 had a bug so that it didn't close timerChangePipe thus causing file descriptor leak. The chan_h323 module has a workaround for this bug - it closes the pipe itself. In the pwlib 1.12.0 this bug has been fixed and PProcess no more contains the timerChangePipe member field. This causes compile error when chan_h323 is built against the fresh pwlib. I've developed a small fix so the workaround is compiled conditionally depending on pwlib version. | ||
Comments: | By: Digium Subversion (svnbot) 2008-05-19 10:16:10 Repository: asterisk Revision: 117081 U branches/1.4/channels/h323/ast_h323.cxx ------------------------------------------------------------------------ r117081 | file | 2008-05-19 10:16:09 -0500 (Mon, 19 May 2008) | 6 lines Make chan_h323 work with pwlib 1.12.0 (closes issue ASTERISK-12045) Reported by: bamby Patches: pwlib_nopipe.diff uploaded by bamby (license 430) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=117081 By: Digium Subversion (svnbot) 2008-05-19 10:18:45 Repository: asterisk Revision: 117082 _U trunk/ U trunk/channels/h323/ast_h323.cxx ------------------------------------------------------------------------ r117082 | file | 2008-05-19 10:18:44 -0500 (Mon, 19 May 2008) | 14 lines Merged revisions 117081 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r117081 | file | 2008-05-19 12:22:10 -0300 (Mon, 19 May 2008) | 6 lines Make chan_h323 work with pwlib 1.12.0 (closes issue ASTERISK-12045) Reported by: bamby Patches: pwlib_nopipe.diff uploaded by bamby (license 430) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=117082 By: Digium Subversion (svnbot) 2008-05-19 10:21:18 Repository: asterisk Revision: 117083 _U branches/1.6.0/ U branches/1.6.0/channels/h323/ast_h323.cxx ------------------------------------------------------------------------ r117083 | file | 2008-05-19 10:21:17 -0500 (Mon, 19 May 2008) | 22 lines Merged revisions 117082 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r117082 | file | 2008-05-19 12:24:44 -0300 (Mon, 19 May 2008) | 14 lines Merged revisions 117081 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r117081 | file | 2008-05-19 12:22:10 -0300 (Mon, 19 May 2008) | 6 lines Make chan_h323 work with pwlib 1.12.0 (closes issue ASTERISK-12045) Reported by: bamby Patches: pwlib_nopipe.diff uploaded by bamby (license 430) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=117083 |