[Home]

Summary:ASTERISK-12041: SIP Call completed elsewhere has 2 colons after Reason
Reporter:Dennis DeDonatis (dennisd)Labels:
Date Opened:2008-05-18 14:45:15Date Closed:2008-05-18 14:53:41
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Reason:: SIP;cause=200;text="Call completed elsewhere"



****** STEPS TO REPRODUCE ******

Use c in Dial()

****** ADDITIONAL INFORMATION ******

static int transmit_request(struct sip_pvt *p, int sipmethod, int seqno, enum xmittype reliable, int newbranch)
{
   struct sip_request resp;

   if (sipmethod == SIP_ACK)
       p->invitestate = INV_CONFIRMED;

   reqprep(&resp, p, sipmethod, seqno, newbranch);
   if (sipmethod == SIP_CANCEL && p->answered_elsewhere)
       add_header(&resp, "Reason:", "SIP;cause=200;text=\"Call completed elsewhere\"");

   add_header_contentLength(&resp, 0);
   return send_request(p, &resp, reliable, seqno ? seqno : p->ocseq);
}

Line 9487 of channels/chan_sip.c:

Reason: should just be Reason as add_header puts the : in there already.

Comments:By: Digium Subversion (svnbot) 2008-05-18 14:52:17

Repository: asterisk
Revision: 116919

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r116919 | russell | 2008-05-18 14:52:14 -0500 (Sun, 18 May 2008) | 3 lines

Remove duplicate colon on Reason header
(closes issue ASTERISK-12041)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=116919
By: Digium Subversion (svnbot) 2008-05-18 14:53:41

Repository: asterisk
Revision: 116922

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r116922 | russell | 2008-05-18 14:53:40 -0500 (Sun, 18 May 2008) | 11 lines

Merged revisions 116919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r116919 | russell | 2008-05-18 14:58:10 -0500 (Sun, 18 May 2008) | 3 lines

Remove duplicate colon on Reason header
(closes issue ASTERISK-12041)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=116922