[Home]

Summary:ASTERISK-12017: Gtalk call from Empathy - no corresponding codecs
Reporter:ph (ph)Labels:
Date Opened:2008-05-14 11:35:33Date Closed:2008-05-23 16:15:26
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_gtalk
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) trunk-12647-1.diff
Description:Gtalk call from empathy 0.23.1 to asterisk
works with asterisk 1.4.10 but not with 1.6-beta8.
We got common codecs but with different names :

JABBER: compteJabber INCOMING: <iq type="set"
to="serveurtable9@10.128.16.10/asterisk" id="6195793178"
from="phil@10.128.16.10/Telepathy"> <session
xmlns="http://www.google.com/session"
initiator="phil@10.128.16.10/Telepathy" type="initiate" id="1960770996">
<description xmlns="http://www.google.com/session/phone"> <payload-type
clockrate="16000" name="speex" id="96"/>
<payload-type clockrate="8000" name="AMR" id="97"/>
<payload-type clockrate="8000" name="GSM" id="3"/>
<payload-type clockrate="8000" name="PCMA" id="8"/>
<payload-type clockrate="8000" name="PCMU" id="0"/>
<payload-type clockrate="16000" name="AMR-WB" id="98"/>
<payload-type clockrate="8000" name="telephone-event" id="99"/>
</description>
</session>
</iq>
[May  7 16:27:16] WARNING[27590]: chan_gtalk.c:1177 gtalk_newcall:
Capabilities don't match : us - 0x27f9fff (g723|gsm|ulaw|alaw|g726|
adpcm|slin|lpc10|g729|speex|ilbc|g726aal2|g722|slin16|jpeg|png|h261|
h263|h263p|h264|mpeg4|t140), peer - 0x0 (nothing), combined - 0x0
(nothing)

JABBER: compteJabber OUTGOING: <iq type='set'
from='serveurtable9@10.128.16.10/asterisk'
to='phil@10.128.16.10/Telepathy' id='aaaac'><session type='reject'
id='1960770996' initiator='phil@10.128.16.10/Telepathy'
xmlns='http://www.google.com/session'/></iq>

JABBER: compteJabber INCOMING: <iq type="result"
to="serveurtable9@10.128.16.10/asterisk" id="aaaac"
from="phil@10.128.16.10/Telepathy"/>
Comments:By: phsultan (phsultan) 2008-05-19 07:45:21

I'll try to install Empathy 0.23.1 on a Linux laptop and test this interesting case. Having Asterisk working with another client than GoogleTalk is a first step toward a total Jingle integration.

Stay tuned!
By: phsultan (phsultan) 2008-05-22 09:56:11

Ok, the SAX parser inside iksemel needs to be fed with XML text *without* any whitespace between tags.

The attached patch should solve this issue, please try it out.
By: ph (ph) 2008-05-23 04:55:14

Great New !!
The patch proposed by Philippe SULTAN resolves the problem.

Thanks Philippe !
By: Digium Subversion (svnbot) 2008-05-23 05:27:16

Repository: asterisk
Revision: 118020

U   trunk/channels/chan_gtalk.c
U   trunk/res/res_jabber.c

------------------------------------------------------------------------
r118020 | phsultan | 2008-05-23 05:27:11 -0500 (Fri, 23 May 2008) | 15 lines

- remove whitespaces between tags in received XML packets before giving
them to the parser ;
- report Gtalk error messages from a buddy to the console.

This patch makes Asterisk "Google Jingle" (chan_gtalk) implementation
work with Empathy. Note that this is only true for audio streams, not
video.

Thank you to PH for his great help!

(closes issue ASTERISK-12017)
Reported by: PH
Patches:
     trunk-12647-1.diff uploaded by phsultan (license 73)
Tested by: phsultan, PH
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118020
By: Digium Subversion (svnbot) 2008-05-23 05:56:15

Repository: asterisk
Revision: 118021

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_gtalk.c
U   branches/1.6.0/res/res_jabber.c

------------------------------------------------------------------------
r118021 | phsultan | 2008-05-23 05:56:13 -0500 (Fri, 23 May 2008) | 23 lines

Merged revisions 118020 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r118020 | phsultan | 2008-05-23 12:33:21 +0200 (Fri, 23 May 2008) | 15 lines

- remove whitespaces between tags in received XML packets before giving
them to the parser ;
- report Gtalk error messages from a buddy to the console.

This patch makes Asterisk "Google Jingle" (chan_gtalk) implementation
work with Empathy. Note that this is only true for audio streams, not
video.

Thank you to PH for his great help!

(closes issue ASTERISK-12017)
Reported by: PH
Patches:
     trunk-12647-1.diff uploaded by phsultan (license 73)
Tested by: phsultan, PH
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118021
By: Digium Subversion (svnbot) 2008-05-23 16:15:26

Repository: asterisk
Revision: 118162

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/CHANGES
U   team/seanbright/resolve-shadow-warnings/apps/app_chanisavail.c
U   team/seanbright/resolve-shadow-warnings/apps/app_voicemail.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_gtalk.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_usbradio.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_vpb.cc
A   team/seanbright/resolve-shadow-warnings/configs/pbx_realtime.conf
A   team/seanbright/resolve-shadow-warnings/doc/cli.txt
U   team/seanbright/resolve-shadow-warnings/include/asterisk/utils.h
U   team/seanbright/resolve-shadow-warnings/main/utils.c
U   team/seanbright/resolve-shadow-warnings/pbx/pbx_realtime.c
U   team/seanbright/resolve-shadow-warnings/res/res_jabber.c
U   team/seanbright/resolve-shadow-warnings/res/res_odbc.c

------------------------------------------------------------------------
r118162 | seanbright | 2008-05-23 16:15:24 -0500 (Fri, 23 May 2008) | 127 lines

Merged revisions 117983,117986,117988,118020,118049,118053,118059,118101,118129,118157,118159 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r117983 | tilghman | 2008-05-22 17:27:00 -0400 (Thu, 22 May 2008) | 2 lines

Fix trunk breakage

................
r117986 | tilghman | 2008-05-22 17:42:50 -0400 (Thu, 22 May 2008) | 2 lines

Add a compatibility option for upgrading realtime extensions

................
r117988 | seanbright | 2008-05-22 17:43:54 -0400 (Thu, 22 May 2008) | 1 line

Split the compile flags out and wire up some dependencies
................
r118020 | phsultan | 2008-05-23 06:33:21 -0400 (Fri, 23 May 2008) | 15 lines

- remove whitespaces between tags in received XML packets before giving
them to the parser ;
- report Gtalk error messages from a buddy to the console.

This patch makes Asterisk "Google Jingle" (chan_gtalk) implementation
work with Empathy. Note that this is only true for audio streams, not
video.

Thank you to PH for his great help!

(closes issue ASTERISK-12017)
Reported by: PH
Patches:
     trunk-12647-1.diff uploaded by phsultan (license 73)
Tested by: phsultan, PH
................
r118049 | russell | 2008-05-23 08:37:31 -0400 (Fri, 23 May 2008) | 17 lines

Merged revisions 118048 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r118048 | russell | 2008-05-23 07:30:53 -0500 (Fri, 23 May 2008) | 9 lines

Don't declare a function that takes variable arguments as inline, because it's
not valid, and on some compilers, will emit a warning.

http://gcc.gnu.org/onlinedocs/gcc/Inline.html#Inline

(closes issue ASTERISK-11712)
Reported by: francesco_r
Patches by Tilghman, final patch by me

........

................
r118053 | tilghman | 2008-05-23 09:00:10 -0400 (Fri, 23 May 2008) | 11 lines

Merged revisions 118052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r118052 | tilghman | 2008-05-23 07:59:16 -0500 (Fri, 23 May 2008) | 3 lines

Add information on using the Asterisk console, including tab command line
completion.  (Closes issue ASTERISK-12044)

........

................
r118059 | tilghman | 2008-05-23 09:20:13 -0400 (Fri, 23 May 2008) | 9 lines

Blocked revisions 118055 via svnmerge

........
r118055 | tilghman | 2008-05-23 08:18:44 -0500 (Fri, 23 May 2008) | 2 lines

Add format type checking for recently de-inlined function

........

................
r118101 | mvanbaak | 2008-05-23 13:12:04 -0400 (Fri, 23 May 2008) | 15 lines

add option 'a' to chanisavail.
If you give chanisavail a list of channels, it will only
return the first available channel.
When this option is set, it will return all the available
channels from the given list.

(closes issue ASTERISK-11673)
Reported by: dagmoller
Patches:
     app_chanisavail-snv.patch-v2.txt uploaded by dagmoller (license 436)
  - major changes by me because russellb pointed out some buffer overflows
    and codeguideline issues.
Converted it all to the ast_str_* api
Tested by: dagmoller, mvanbaak

................
r118129 | tilghman | 2008-05-23 14:09:14 -0400 (Fri, 23 May 2008) | 3 lines

Protect the object from changing while the 'odbc show' CLI command is running
(Closes issue ASTERISK-12065)

................
r118157 | mmichelson | 2008-05-23 15:57:40 -0400 (Fri, 23 May 2008) | 10 lines

Use a deep copy on strings that come from ast_events. Otherwise it is
likely that after the event is freed, we no longer refer to valid memory.

(closes issue ASTERISK-12073)
Reported by: tomo1657
Patches:
     12712.patch uploaded by putnopvut (license 60)
Tested by: tomo1657


................
r118159 | mmichelson | 2008-05-23 16:55:02 -0400 (Fri, 23 May 2008) | 4 lines

Get rid of warnings for those silly compilers which warn when freeing
a const pointer


................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118162