[Home]

Summary:ASTERISK-12010: [patch] default for pridialplan in chan_zap national=>unknown
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2008-05-12 18:32:06Date Closed:2008-05-19 15:02:10
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) pridialplan_unknown_2.diff
( 1) pridialplan_unknown.diff
Description:Following a short discussion in asterisk-dev[1], I would like to ask to set the defaults for pridialplan to "unknown" . Patch attached. It also updates the sample config file and the CHANGES file.

The patch also sets the default of prilocaldialplan, though I must admit I don't really understand where it is used.The text in the sample config file needs some fixing.

[1] http://archives.free.net.ph/message/20080504.093941.1db92797.en.html
Comments:By: Tilghman Lesher (tilghman) 2008-05-16 16:32:40

I believe prilocaldialplan sets the caller parameters, whereas pridialplan sets the called parameters.  Essentially the difference between ANI and DNIS.  So national may actually make more sense for prilocaldialplan, as the number typically used for callerid is not usually prefixed with a '1', as would be needed for 'unknown'.


By: Tzafrir Cohen (tzafrir) 2008-05-19 14:36:10

New patch added. Hopefully what I wrote in the samples file is actually correct.
By: Digium Subversion (svnbot) 2008-05-19 15:00:48

Repository: asterisk
Revision: 117182

U   trunk/CHANGES
U   trunk/channels/chan_zap.c
U   trunk/configs/zapata.conf.sample

------------------------------------------------------------------------
r117182 | tilghman | 2008-05-19 15:00:45 -0500 (Mon, 19 May 2008) | 7 lines

Change the default for the pridialplan parameter to the far more common case of
'unknown', and better document the use of each parameter.
(closes issue ASTERISK-12010)
Reported by: tzafrir
Patches:
      pridialplan_unknown_2.diff uploaded by tzafrir (license 46)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=117182
By: Digium Subversion (svnbot) 2008-05-19 15:02:10

Repository: asterisk
Revision: 117183

_U  branches/1.6.0/

------------------------------------------------------------------------
r117183 | tilghman | 2008-05-19 15:02:07 -0500 (Mon, 19 May 2008) | 14 lines

Blocked revisions 117182 via svnmerge

........
r117182 | tilghman | 2008-05-19 15:06:38 -0500 (Mon, 19 May 2008) | 7 lines

Change the default for the pridialplan parameter to the far more common case of
'unknown', and better document the use of each parameter.
(closes issue ASTERISK-12010)
Reported by: tzafrir
Patches:
      pridialplan_unknown_2.diff uploaded by tzafrir (license 46)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=117183