[Home]

Summary:ASTERISK-11967: [patch] Don't work -dev-mode and appropriate fix for app_fax
Reporter:Igor Goncharovsky (igorg)Labels:
Date Opened:2008-05-03 22:14:14Date Closed:2008-05-05 11:06:21
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Addons/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) addons_dev_mode.diff
( 1) addons_dev_mode.v2.diff
Description:I have found that ./configure --enable-dev-mode never works science added. Also found that app_fax have unused variables and problem with format strings.
Comments:By: Michiel van Baak (mvanbaak) 2008-05-04 16:47:59

<nitpick_mode>
+ if (level == SPAN_LOG_ERROR){
should be:
+ if (level == SPAN_LOG_ERROR) {
</nitpick_mode>
By: Clod Patry (junky) 2008-05-04 19:37:15

app_fax is not in the Asterisk tree.
This is a third-party application, so not sure if this belongs here.
By: Igor Goncharovsky (igorg) 2008-05-04 20:57:21

app_fax already in 1.6.0 *Addons*

mvanbaak: thank you for you nitpick check and pointing this :) one-byte-more patch uploaded
By: Digium Subversion (svnbot) 2008-05-05 11:05:36

Repository: asterisk-addons
Revision: 588

U   trunk/Makefile
U   trunk/apps/app_fax.c

------------------------------------------------------------------------
r588 | qwell | 2008-05-05 11:05:31 -0500 (Mon, 05 May 2008) | 9 lines

Make --enable-dev-mode actually work.

Fix app_fax build to not give warnings (which are errors when dev-mode actually works).

(closes issue ASTERISK-11967)
Reported by: IgorG
Patches:
     addons_dev_mode.v2.diff uploaded by IgorG (license 20)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=588
By: Digium Subversion (svnbot) 2008-05-05 11:06:21

Repository: asterisk-addons
Revision: 589

_U  branches/1.6.0/
U   branches/1.6.0/Makefile
U   branches/1.6.0/apps/app_fax.c

------------------------------------------------------------------------
r589 | qwell | 2008-05-05 11:06:20 -0500 (Mon, 05 May 2008) | 17 lines

Merged revisions 588 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/trunk

........
r588 | qwell | 2008-05-05 11:11:10 -0500 (Mon, 05 May 2008) | 9 lines

Make --enable-dev-mode actually work.

Fix app_fax build to not give warnings (which are errors when dev-mode actually works).

(closes issue ASTERISK-11967)
Reported by: IgorG
Patches:
     addons_dev_mode.v2.diff uploaded by IgorG (license 20)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=589