[Home]

Summary:ASTERISK-11937: Line name issue on Cisco 7940 and 7960 phones
Reporter:Christopher Eades (chroweb)Labels:
Date Opened:2008-04-29 06:48:24Date Closed:2008-06-15 03:46:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I've got a 7940 and 7960 phone that when I switched from chan_sccp to chan_skinny lost the ability to independently set the line name. Upon further inspection (tcpdump, Wireshark, source view) I found that chan_skinny does not send "as full" a packet for LINE_STAT_RES_MESSAGE to the phone. Basically there are three useful strings (that I can tell) at the end of the packet: lineDirNumber[24], lineDisplayName[24], [space:20 bytes/5 DWORDs] and lineDescription[24];

The way that it is in chan_skinny.c is lacking the lineDescription (I added that). What happens is the "linelabel" parameter, from skinny.conf, gets sent to EACH line (one line updated per packet transaction). The description field is NEVER set (blank) so the phones show the line numbers instead of the text. This drove me crazy so I added the ability to add a description to the packet.  :)

I've created a patch that assumes the original is chan_skinny.c.org and the newly modified one is chan_skinny.c. Essentially I've added a "description" field to the struct line_stat_res_message, added "description" as a parameter to skinny.conf and made sure it was memcpy'd to the packet before dispatch to the phone.


****** STEPS TO REPRODUCE ******

Configure skinny.conf and watch all your lines, and the name of the phone, have the same label. Lines display as their numbers and not the "displayName" (which doesn't display at all).

Something else I figured out... the top of the phone, in the black banner, only displays the first "displayName" parameter. You can change it to whatever you want in skinny.conf as many times as you want (more lines) but it only displays the first one it received. This method assumes that you have only one linelabel directive in your configuration file (and it appears before any line directives). You then name your lines with "description = My Great Line".

****** ADDITIONAL INFORMATION ******

I don't see an upload function here, so I've placed them on my webserver:
http://chromaxs.com/asterisk/

Both the patch and the modified source file are there. (This is from Asterisk 1.4.19 so I'm not sure if anything really changed to 1.4.19.1...)

Firmware running on the phones:
7940 load information: P00307020200
7960 load information: P00307020200
Comments:By: Joshua C. Colp (jcolp) 2008-04-29 06:53:33

There is indeed upload functionality on here, and you must use it for this to be accepted. You must also agree to the online contributor agreement and have it approved before we will be able to look at the patches.
By: Michiel van Baak (mvanbaak) 2008-05-17 09:28:00

Can you please upload the patch ?
By: Michiel van Baak (mvanbaak) 2008-06-04 16:26:41

Can you please upload the patch ?
By: Michiel van Baak (mvanbaak) 2008-06-15 03:46:01

Closed because of no response from reporter.
If you want to upload the patch feel free to reopen, or ask me to reopen it for you.