Summary:	ASTERISK-11923: [patch] vmail.cgi problem with forwarding without selecting a message
Reporter:	Joe Pukepail (pukepail)	Labels:
Date Opened:	2008-04-25 18:13:01	Date Closed:	2008-04-26 20:49:17
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch.diff
Description:	If you are at your mailbox and do not select any messages and select a mailbox and click forward, you will received this error: Software error: Invalid old Message It will also create a orphaned .lock in the mailbox of the person you are forwarding attempting to forward a message to, causing loss of voicemail, etc. ****** ADDITIONAL INFORMATION ****** Happenes on 1.4.19 and svn trunk. I have created a patch that will give a warning if someone clicks on "delete" or clicks "forward" without selecting a mailbox.
Comments:	By: Joe Pukepail (pukepail) 2008-04-25 18:17:43 Sorry for the duplicate upload. This is a patch I have created, I'm not a professional developer, but I think this is the correct fix. By: Digium Subversion (svnbot) 2008-04-26 08:10:13 Repository: asterisk Revision: 114689 U   branches/1.4/contrib/scripts/vmail.cgi ------------------------------------------------------------------------ r114689 | tilghman | 2008-04-26 08:09:57 -0500 (Sat, 26 Apr 2008) | 6 lines Clicking forward without selecting a message leaves an errant .lock file. (closes issue ASTERISK-11923) Reported by: pukepail Patches:       patch.diff uploaded by pukepail (license 431) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114689 By: Digium Subversion (svnbot) 2008-04-26 08:12:01 Repository: asterisk Revision: 114690 _U  trunk/ U   trunk/contrib/scripts/vmail.cgi ------------------------------------------------------------------------ r114690 | tilghman | 2008-04-26 08:11:59 -0500 (Sat, 26 Apr 2008) | 14 lines Merged revisions 114689 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114689 | tilghman | 2008-04-26 08:15:21 -0500 (Sat, 26 Apr 2008) | 6 lines Clicking forward without selecting a message leaves an errant .lock file. (closes issue ASTERISK-11923) Reported by: pukepail Patches:       patch.diff uploaded by pukepail (license 431) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114690 By: Digium Subversion (svnbot) 2008-04-26 08:12:57 Repository: asterisk Revision: 114691 _U  branches/1.6.0/ U   branches/1.6.0/contrib/scripts/vmail.cgi ------------------------------------------------------------------------ r114691 | tilghman | 2008-04-26 08:12:55 -0500 (Sat, 26 Apr 2008) | 22 lines Merged revisions 114690 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114690 | tilghman | 2008-04-26 08:17:19 -0500 (Sat, 26 Apr 2008) | 14 lines Merged revisions 114689 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114689 | tilghman | 2008-04-26 08:15:21 -0500 (Sat, 26 Apr 2008) | 6 lines Clicking forward without selecting a message leaves an errant .lock file. (closes issue ASTERISK-11923) Reported by: pukepail Patches:       patch.diff uploaded by pukepail (license 431) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114691 By: Digium Subversion (svnbot) 2008-04-26 19:17:25 Repository: asterisk Revision: 114694 _U  team/file/audiohook-chains/ U   team/file/audiohook-chains/CHANGES U   team/file/audiohook-chains/apps/app_chanspy.c U   team/file/audiohook-chains/channels/chan_iax2.c U   team/file/audiohook-chains/channels/chan_sip.c U   team/file/audiohook-chains/contrib/scripts/vmail.cgi U   team/file/audiohook-chains/pbx/pbx_lua.c ------------------------------------------------------------------------ r114694 | file | 2008-04-26 19:17:22 -0500 (Sat, 26 Apr 2008) | 76 lines Merged revisions 114674,114676,114678,114683,114690,114692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114674 | russell | 2008-04-25 19:00:35 -0300 (Fri, 25 Apr 2008) | 11 lines Merged revisions 114673 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114673 | russell | 2008-04-25 16:54:40 -0500 (Fri, 25 Apr 2008) | 3 lines Use consistent logic for checking to see if a call number has been chosen yet. Also, remove some redundant logic I recently added in a fix. ........ ................ r114676 | russell | 2008-04-25 19:04:46 -0300 (Fri, 25 Apr 2008) | 7 lines Lock the channel around datastore access (closes issue ASTERISK-11922) Reported by: mnicholson Patches:      pbx_lua4.diff uploaded by mnicholson (license 96) ................ r114678 | mmichelson | 2008-04-25 19:24:32 -0300 (Fri, 25 Apr 2008) | 11 lines Adding a new option, 'B' to app_chanspy. This option allows the spy to barge on the call. It is like the existing whisper option, except that it allows the spy to talk to both sides of the conversation on which he is spying. This feature has existed in Switchvox, and this merges the functionality into Asterisk. (AST-32) ................ r114683 | tilghman | 2008-04-25 23:48:56 -0300 (Fri, 25 Apr 2008) | 8 lines Add 'sip qualify peer <peer>' command (with AMI SIPqualifypeer) (closes issue ASTERISK-11920) Reported by: ctooley Patches:       sip_qualify_peer.diff.2 uploaded by ctooley (license 136)       some modifications for trunk by Corydon76 Tested by: Corydon76 ................ r114690 | tilghman | 2008-04-26 10:17:19 -0300 (Sat, 26 Apr 2008) | 14 lines Merged revisions 114689 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114689 | tilghman | 2008-04-26 08:15:21 -0500 (Sat, 26 Apr 2008) | 6 lines Clicking forward without selecting a message leaves an errant .lock file. (closes issue ASTERISK-11923) Reported by: pukepail Patches:       patch.diff uploaded by pukepail (license 431) ........ ................ r114692 | tilghman | 2008-04-26 12:08:51 -0300 (Sat, 26 Apr 2008) | 2 lines Unleak reference ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114694 By: Digium Subversion (svnbot) 2008-04-26 20:49:17 Repository: asterisk Revision: 114698 _U  team/seanbright/res-jabber-astobj2/ U   team/seanbright/res-jabber-astobj2/channels/chan_sip.c U   team/seanbright/res-jabber-astobj2/configure U   team/seanbright/res-jabber-astobj2/configure.ac U   team/seanbright/res-jabber-astobj2/contrib/scripts/vmail.cgi ------------------------------------------------------------------------ r114698 | seanbright | 2008-04-26 20:49:15 -0500 (Sat, 26 Apr 2008) | 43 lines Merged revisions 114690,114692,114696 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114690 | tilghman | 2008-04-26 09:17:19 -0400 (Sat, 26 Apr 2008) | 14 lines Merged revisions 114689 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114689 | tilghman | 2008-04-26 08:15:21 -0500 (Sat, 26 Apr 2008) | 6 lines Clicking forward without selecting a message leaves an errant .lock file. (closes issue ASTERISK-11923) Reported by: pukepail Patches:       patch.diff uploaded by pukepail (license 431) ........ ................ r114692 | tilghman | 2008-04-26 11:08:51 -0400 (Sat, 26 Apr 2008) | 2 lines Unleak reference ................ r114696 | seanbright | 2008-04-26 21:28:32 -0400 (Sat, 26 Apr 2008) | 13 lines Merged revisions 114695 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114695 | seanbright | 2008-04-26 21:26:15 -0400 (Sat, 26 Apr 2008) | 5 lines When we don't explicitly pass a path to the --with-tds configure option, we may end up finding tds.h in /usr/local/include instead of /usr/include.  If this happens, the grep that looks for the version (from tdsver.h) will fail and we'll have some problems during the build. ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114698