Summary:	ASTERISK-11861: configuration option toneduration not working with zaptel 1.4.10
Reporter:	Marcus Hunger (fnordian)	Labels:
Date Opened:	2008-04-16 06:07:37	Date Closed:	2008-06-07 14:00:34
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_zap
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	hi, the toneduration option is not working with zaptel 1.4.10. this is caused by a change of struct zt_dialparams. when setting toneduration, zt_dialparams.mfr2_tonelen is uninitialized so the ioctl for ZT_SET_DIALPARAMS fails.
Comments:	By: Tzafrir Cohen (tzafrir) 2008-04-16 09:36:18 A zaptel bug ? (the interface shouldn't have changed?) By: Marcus Hunger (fnordian) 2008-04-16 11:42:29 the structure has been changed: http://svn.digium.com/view/zaptel/branches/1.4/kernel/zaptel.h?r1=3854&r2=4063 By: Digium Subversion (svnbot) 2008-04-16 15:41:28 Repository: asterisk Revision: 114184 U   branches/1.4/channels/chan_zap.c ------------------------------------------------------------------------ r114184 | kpfleming | 2008-04-16 15:41:27 -0500 (Wed, 16 Apr 2008) | 6 lines use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10) (closes issue ASTERISK-11861) Reported by: fnordian ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114184 By: Digium Subversion (svnbot) 2008-04-16 15:42:19 Repository: asterisk Revision: 114185 _U  trunk/ U   trunk/channels/chan_zap.c ------------------------------------------------------------------------ r114185 | kpfleming | 2008-04-16 15:42:19 -0500 (Wed, 16 Apr 2008) | 14 lines Merged revisions 114184 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114184 | kpfleming | 2008-04-16 15:46:38 -0500 (Wed, 16 Apr 2008) | 6 lines use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10) (closes issue ASTERISK-11861) Reported by: fnordian ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114185 By: Digium Subversion (svnbot) 2008-04-16 15:43:09 Repository: asterisk Revision: 114186 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_zap.c ------------------------------------------------------------------------ r114186 | kpfleming | 2008-04-16 15:43:09 -0500 (Wed, 16 Apr 2008) | 22 lines Merged revisions 114185 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114185 | kpfleming | 2008-04-16 15:47:30 -0500 (Wed, 16 Apr 2008) | 14 lines Merged revisions 114184 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114184 | kpfleming | 2008-04-16 15:46:38 -0500 (Wed, 16 Apr 2008) | 6 lines use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10) (closes issue ASTERISK-11861) Reported by: fnordian ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114186 By: Marcus Hunger (fnordian) 2008-04-17 01:06:37 unfortunatly, this doesnt solve the issue. mfr2_tonelen must be initialized correctly (10 < mfr2_tonelen < 4000) for ioctl ZT_SET_DIALPARAMS to work correctly. By: Kevin P. Fleming (kpfleming) 2008-04-17 07:13:45 Ugh... you are correct. I'm changing Zaptel so that it will only accept individual parameters from the dialparams structure that are in acceptable ranges, and ignore all the rest instead of returning an error. By: Digium Subversion (svnbot) 2008-04-17 07:15:17 Repository: zaptel Revision: 4173 U   branches/1.4/kernel/zaptel-base.c ------------------------------------------------------------------------ r4173 | kpfleming | 2008-04-17 07:15:14 -0500 (Thu, 17 Apr 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ------------------------------------------------------------------------ http://svn.digium.com/view/zaptel?view=rev&revision=4173 By: Digium Subversion (svnbot) 2008-04-17 12:30:50 Repository: asterisk Revision: 114214 _U  team/group/multiparking/ U   team/group/multiparking/CHANGES U   team/group/multiparking/Makefile U   team/group/multiparking/apps/app_chanspy.c U   team/group/multiparking/apps/app_externalivr.c U   team/group/multiparking/apps/app_festival.c U   team/group/multiparking/apps/app_ices.c U   team/group/multiparking/apps/app_mp3.c U   team/group/multiparking/apps/app_nbscat.c U   team/group/multiparking/apps/app_zapras.c U   team/group/multiparking/channels/chan_sip.c U   team/group/multiparking/channels/chan_zap.c U   team/group/multiparking/configs/sip.conf.sample U   team/group/multiparking/doc/CODING-GUIDELINES A   team/group/multiparking/doc/chan_sip-perf-testing.txt U   team/group/multiparking/include/asterisk/app.h U   team/group/multiparking/include/asterisk/astobj2.h A   team/group/multiparking/include/asterisk/dlinkedlists.h U   team/group/multiparking/include/asterisk/dsp.h U   team/group/multiparking/include/asterisk/frame.h U   team/group/multiparking/include/asterisk/lock.h U   team/group/multiparking/include/asterisk/logger.h U   team/group/multiparking/include/asterisk/sched.h U   team/group/multiparking/main/app.c U   team/group/multiparking/main/asterisk.c U   team/group/multiparking/main/astobj2.c U   team/group/multiparking/main/dsp.c U   team/group/multiparking/main/event.c U   team/group/multiparking/main/frame.c U   team/group/multiparking/main/logger.c U   team/group/multiparking/main/sched.c U   team/group/multiparking/main/utils.c U   team/group/multiparking/res/res_agi.c U   team/group/multiparking/res/res_jabber.c U   team/group/multiparking/res/res_musiconhold.c A   team/group/multiparking/tests/test_dlinklists.c U   team/group/multiparking/utils/Makefile A   team/group/multiparking/utils/refcounter.c ------------------------------------------------------------------------ r114214 | mvanbaak | 2008-04-17 12:30:47 -0500 (Thu, 17 Apr 2008) | 189 lines Merged revisions 114172,114174-114175,114181-114183,114185,114187-114188,114190,114192,114194,114196,114199,114201-114202,114205,114208,114212 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114172 | murf | 2008-04-16 19:14:18 +0200 (Wed, 16 Apr 2008) | 1 line Introducing doubly linked lists to trunk from branch team/murf/bug11210. ................ r114174 | qwell | 2008-04-16 19:31:02 +0200 (Wed, 16 Apr 2008) | 14 lines Blocked revisions 114173 via svnmerge ........ r114173 | qwell | 2008-04-16 12:30:09 -0500 (Wed, 16 Apr 2008) | 7 lines Fix "fallthrough" behavior here, so config options in a previously configured user don't override settings in general. (closes issue ASTERISK-11863) Reported by: tzafrir Patches:      chanzap_users_sections.diff uploaded by tzafrir (license 46) ........ ................ r114175 | murf | 2008-04-16 19:45:28 +0200 (Wed, 16 Apr 2008) | 1 line Introducing various astobj2 enhancements, chief being a refcount tracing feature, and various documentation updates in astobj2.h, and the addition of standalone utility, refcounter, that will filter the trace output for unbalanced, unfreed objects. This comes from the team/murf/bug11210 branch. ................ r114181 | tilghman | 2008-04-16 22:00:27 +0200 (Wed, 16 Apr 2008) | 10 lines Blocked revisions 114180 via svnmerge ........ r114180 | tilghman | 2008-04-16 14:59:37 -0500 (Wed, 16 Apr 2008) | 3 lines Backport revisions for latest vpb drivers to 1.4 (Closes issue ASTERISK-11862) ........ ................ r114182 | murf | 2008-04-16 22:09:39 +0200 (Wed, 16 Apr 2008) | 1 line Introducing a small upgrade to the ast_sched_xxx  facility, to keep it from eating up lots of cpu cycles. See CHANGES. From the team/murf/bug11210 branch. ................ r114183 | murf | 2008-04-16 22:28:08 +0200 (Wed, 16 Apr 2008) | 1 line Introducing a small optimization to event_unsubscribe; events now use a Doubly-Linked list for events, gives fast deletions, for the sake of channel driver mwi events. From team/murf/bug11210. ................ r114185 | kpfleming | 2008-04-16 22:47:30 +0200 (Wed, 16 Apr 2008) | 14 lines Merged revisions 114184 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114184 | kpfleming | 2008-04-16 15:46:38 -0500 (Wed, 16 Apr 2008) | 6 lines use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10) (closes issue ASTERISK-11861) Reported by: fnordian ........ ................ r114187 | murf | 2008-04-16 22:54:41 +0200 (Wed, 16 Apr 2008) | 1 line A small enhancement-- I added the routine log_show_lock to utils.c, which if the mentioned lock has been acquired, this routine will log to the console the normal info about that lock you'd see from the CLI when you do a 'core show locks'. It's solely for debug-- if the lock is NOT acquired, there is no output. I use it to show 'unexpected' locks, to see where/why a lock is pre-locked. This command is to be called from points of interest, like just before a trylock, and helps to spot fleeting, highly temporal locks that normally are not locked... ................ r114188 | tilghman | 2008-04-17 00:57:54 +0200 (Thu, 17 Apr 2008) | 2 lines Standardized routines for forking processes (keeps all the specialized code in one place). ................ r114190 | murf | 2008-04-17 01:53:27 +0200 (Thu, 17 Apr 2008) | 1 line This is the scariest commit I've done in a long time. This is the astobj2-ification of chan_sip. I've tested a number of scenarios like crazy. It used to have 4x the call setup/teardown performance of trunk, but now it's roughly at parity. I will attempt to find the bottlenecks and get it back to the 4x mark. The changes made were somewhat invasive, but the value to the community of these upgrades outweighs waiting further for more testing. Every change being made to chan_sip was lousing this code up when we tried to merge. Peers, Users, Dialogs, are all now astobj2 objects, indexed via hashtables. Refcounting is used to track objects and free them at the bitter end of their lives. Please file issues on bugs.digium.com, and PLEASE, please, please be patient. One natural advantage to all the hash-table work is that loading large sip.conf files full of thousands of peers now goes much faster. One more please: PLEASE help thrash this code and test it. ................ r114192 | seanbright | 2008-04-17 12:55:05 +0200 (Thu, 17 Apr 2008) | 9 lines Merged revisions 114191 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114191 | seanbright | 2008-04-17 06:51:20 -0400 (Thu, 17 Apr 2008) | 1 line Make sure we have enough room for the recording's filename. ........ ................ r114194 | seanbright | 2008-04-17 14:25:23 +0200 (Thu, 17 Apr 2008) | 1 line Update the CHANGES file with yesterday's ChanSpy change.  Sorry Kevin, just saw your e-mail. ................ r114196 | tilghman | 2008-04-17 14:59:04 +0200 (Thu, 17 Apr 2008) | 16 lines Merged revisions 114195 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114195 | tilghman | 2008-04-17 07:56:38 -0500 (Thu, 17 Apr 2008) | 8 lines Add special case for when the agi cannot be executed, to comply with the documentation that we return failure in that case. (closes issue ASTERISK-11866) Reported by: fmueller Patches:       20080416__bug12462.diff.txt uploaded by Corydon76 (license 14) Tested by: fmueller ........ ................ r114199 | phsultan | 2008-04-17 15:46:17 +0200 (Thu, 17 Apr 2008) | 10 lines Merged revisions 114198 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114198 | phsultan | 2008-04-17 15:42:23 +0200 (Thu, 17 Apr 2008) | 2 lines Use keepalives effectively in order diagnose bug ASTERISK-11838. ........ ................ r114201 | murf | 2008-04-17 16:45:16 +0200 (Thu, 17 Apr 2008) | 1 line Thanks to snuff for finding these omissions ................ r114202 | tilghman | 2008-04-17 17:12:52 +0200 (Thu, 17 Apr 2008) | 2 lines fileio.h does not exist; io.h does, though. ................ r114205 | russell | 2008-04-17 18:25:29 +0200 (Thu, 17 Apr 2008) | 11 lines Merged revisions 114204 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114204 | russell | 2008-04-17 11:23:45 -0500 (Thu, 17 Apr 2008) | 3 lines Fix the bininstall target to install from subdirs, as well. (closes issue AST-8, patch from bmd at switchvox) ........ ................ r114208 | mmichelson | 2008-04-17 18:40:12 +0200 (Thu, 17 Apr 2008) | 20 lines Merged revisions 114207 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114207 | mmichelson | 2008-04-17 11:28:03 -0500 (Thu, 17 Apr 2008) | 12 lines It was possible for a reference to a frame which was part of a freed DSP to still be referenced, leading to memory corruption and eventual crashes. This code change ensures that the dsp is freed when we are finished with the frame. This change is very similar to a change Russell made with translators back a month or so ago. (closes issue ASTERISK-11443) Reported by: destiny6628 Patches:      11999.patch uploaded by putnopvut (license 60) Tested by: destiny6628, victoryure ........ ................ r114212 | mmichelson | 2008-04-17 18:51:09 +0200 (Thu, 17 Apr 2008) | 11 lines Blocked revisions 114211 via svnmerge ........ r114211 | mmichelson | 2008-04-17 11:50:46 -0500 (Thu, 17 Apr 2008) | 4 lines Add prototype for ast_dsp_frame_freed. I'm not sure how this was compiling before... ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114214 By: Digium Subversion (svnbot) 2008-04-19 16:44:21 Repository: zaptel Revision: 4182 _U  team/mattf/zaptel-1.4-raceandlockingfix/ U   team/mattf/zaptel-1.4-raceandlockingfix/Makefile A   team/mattf/zaptel-1.4-raceandlockingfix/build_tools/zaptel_svn_tarball U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/xpp/.version U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/zaptel-base.c U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/ztdynamic.c ------------------------------------------------------------------------ r4182 | mattf | 2008-04-19 16:44:18 -0500 (Sat, 19 Apr 2008) | 59 lines Merged revisions 4165-4170,4173,4175-4176 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r4165 | tzafrir | 2008-04-10 11:15:23 -0500 (Thu, 10 Apr 2008) | 5 lines Officially bumping xpp version (xpp/.version) to 5566 . Merged revisions 4164 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4166 | tzafrir | 2008-04-10 13:11:51 -0500 (Thu, 10 Apr 2008) | 2 lines zaptel_svn_tarball - get a tarball fron an SVN snapshot. ........ r4167 | sruffell | 2008-04-10 16:01:59 -0500 (Thu, 10 Apr 2008) | 2 lines Fixed typo in makefile which was preventing make from installing the udev rules. ........ r4168 | dbailey | 2008-04-10 17:25:30 -0500 (Thu, 10 Apr 2008) | 3 lines Correct problem where drivers implementing echocan_with_params was not getting called to disable the echo canceller ........ r4169 | mattf | 2008-04-11 16:16:47 -0500 (Fri, 11 Apr 2008) | 1 line Make sure that we disable the echo canceller on the old style echocan() function even if parameters are passed in. ........ r4170 | mattf | 2008-04-11 16:17:55 -0500 (Fri, 11 Apr 2008) | 1 line Take out part of a commit to the wct4xxp driver that wasn't supposed to go in ........ r4173 | kpfleming | 2008-04-17 07:20:26 -0500 (Thu, 17 Apr 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ........ r4175 | tzafrir | 2008-04-17 09:27:50 -0500 (Thu, 17 Apr 2008) | 5 lines Avoid a double-free in ztdynamic.c ztdynamic_chanfree.diff from bug ZAP-308 . Merged revisions 4174 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4176 | jdixon | 2008-04-18 10:19:00 -0500 (Fri, 18 Apr 2008) | 2 lines Fixed monitoring of zap pseudo channels ........ ------------------------------------------------------------------------ http://svn.digium.com/view/zaptel?view=rev&revision=4182 By: Digium Subversion (svnbot) 2008-05-02 12:22:39 Repository: zaptel Revision: 4220 _U  team/mattf/zaptel-1.4-stackcleanup/ U   team/mattf/zaptel-1.4-stackcleanup/Makefile U   team/mattf/zaptel-1.4-stackcleanup/README A   team/mattf/zaptel-1.4-stackcleanup/build_tools/zaptel_svn_tarball U   team/mattf/zaptel-1.4-stackcleanup/kernel/pciradio.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/wctdm.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/.version U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/Kbuild U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/utils/zconf/Zaptel/Config/Defaults.pm U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel-base.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel.h U   team/mattf/zaptel-1.4-stackcleanup/kernel/ztdynamic.c U   team/mattf/zaptel-1.4-stackcleanup/zaptel.init U   team/mattf/zaptel-1.4-stackcleanup/ztcfg.c ------------------------------------------------------------------------ r4220 | mattf | 2008-05-02 12:22:37 -0500 (Fri, 02 May 2008) | 143 lines Merged revisions 4165-4170,4173,4175-4176,4183-4185,4187,4190-4196,4213,4217 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r4165 | tzafrir | 2008-04-10 11:15:23 -0500 (Thu, 10 Apr 2008) | 5 lines Officially bumping xpp version (xpp/.version) to 5566 . Merged revisions 4164 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4166 | tzafrir | 2008-04-10 13:11:51 -0500 (Thu, 10 Apr 2008) | 2 lines zaptel_svn_tarball - get a tarball fron an SVN snapshot. ........ r4167 | sruffell | 2008-04-10 16:01:59 -0500 (Thu, 10 Apr 2008) | 2 lines Fixed typo in makefile which was preventing make from installing the udev rules. ........ r4168 | dbailey | 2008-04-10 17:25:30 -0500 (Thu, 10 Apr 2008) | 3 lines Correct problem where drivers implementing echocan_with_params was not getting called to disable the echo canceller ........ r4169 | mattf | 2008-04-11 16:16:47 -0500 (Fri, 11 Apr 2008) | 1 line Make sure that we disable the echo canceller on the old style echocan() function even if parameters are passed in. ........ r4170 | mattf | 2008-04-11 16:17:55 -0500 (Fri, 11 Apr 2008) | 1 line Take out part of a commit to the wct4xxp driver that wasn't supposed to go in ........ r4173 | kpfleming | 2008-04-17 07:20:26 -0500 (Thu, 17 Apr 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ........ r4175 | tzafrir | 2008-04-17 09:27:50 -0500 (Thu, 17 Apr 2008) | 5 lines Avoid a double-free in ztdynamic.c ztdynamic_chanfree.diff from bug ZAP-308 . Merged revisions 4174 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4176 | jdixon | 2008-04-18 10:19:00 -0500 (Fri, 18 Apr 2008) | 2 lines Fixed monitoring of zap pseudo channels ........ r4183 | mattf | 2008-04-19 16:54:03 -0500 (Sat, 19 Apr 2008) | 1 line Partial fix for DAHLIN-5.  Fixes potential race condition in open and close routines for zaptel devices ........ r4184 | mattf | 2008-04-19 16:56:06 -0500 (Sat, 19 Apr 2008) | 1 line Remove unintentional svn property addition ........ r4185 | mattf | 2008-04-19 17:05:42 -0500 (Sat, 19 Apr 2008) | 1 line Fix compiler from complaining ........ r4187 | tzafrir | 2008-04-21 16:27:59 -0500 (Mon, 21 Apr 2008) | 4 lines Zaptel::Config::Default - don't die if no config file. (Accidentally left out of the merge from 1.2) ........ r4190 | jdixon | 2008-04-22 17:07:08 -0500 (Tue, 22 Apr 2008) | 2 lines Fixed problem preventing multiple channels from using multiple CTCSS ........ r4191 | jdixon | 2008-04-22 23:36:22 -0500 (Tue, 22 Apr 2008) | 2 lines Updated to latest code, fixed bug in serial i/o ........ r4192 | tzafrir | 2008-04-23 04:48:56 -0500 (Wed, 23 Apr 2008) | 2 lines Bumped into yet another incompatibility. ........ r4193 | tzafrir | 2008-04-23 14:20:53 -0500 (Wed, 23 Apr 2008) | 10 lines A test for a specific #define in zconfig.h was done by invoking cpp . Sadly the change of CFLAGS handling in kernel 2.6.24 meant that it is no longer as easy to invoke cpp on our own. Impact: On kernel >= 2.6.24, xpd_bri never got built, even if the bri_dchan patch was applied. Fix: use a simpler grep instead. Hopefully noone passes it through other means. This should hopfully fix issue ZAP-312 . ........ r4194 | sruffell | 2008-04-24 13:17:12 -0500 (Thu, 24 Apr 2008) | 5 lines Fixes a regression in versions 1.2.25 and 1.4.19 identified by korihor where the wctdm driver was no longer properly recognizing polarity reversals. (closes issue ZAP-309) ........ r4195 | qwell | 2008-04-25 13:10:06 -0500 (Fri, 25 Apr 2008) | 1 line Based on a comment made by moy in #asterisk-dev, and the surrounding code in these functions, I believe that this is what was actually intended in r4130. ........ r4196 | qwell | 2008-04-25 15:47:07 -0500 (Fri, 25 Apr 2008) | 7 lines Since MF R2 tones are generated continuously, we need to not set the dialing status. (closes issue ZAP-317) Reported by: moy Patches:      zaptel-mf-dialing-rev4195.patch uploaded by moy (license 222) ........ r4213 | twilson | 2008-05-01 11:46:44 -0500 (Thu, 01 May 2008) | 2 lines Allow $(ARCH) to be overridden and pass on through $(KMAKE) ........ r4217 | qwell | 2008-05-01 14:37:07 -0500 (Thu, 01 May 2008) | 7 lines Clarify a message.  Some hardware doesn't provide timing, so this could be confusing. (closes issue ZAP-313) Reported by: panderson Patches:      zaptel.init.patch uploaded by panderson (license 469) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/zaptel?view=rev&revision=4220 By: Digium Subversion (svnbot) 2008-06-07 13:59:40 Repository: dahdi Revision: 4173 U   branches/1.4/kernel/zaptel-base.c ------------------------------------------------------------------------ r4173 | kpfleming | 2008-06-07 13:59:40 -0500 (Sat, 07 Jun 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=4173 By: Digium Subversion (svnbot) 2008-06-07 13:59:51 Repository: dahdi Revision: 4182 _U  team/mattf/zaptel-1.4-raceandlockingfix/ U   team/mattf/zaptel-1.4-raceandlockingfix/Makefile A   team/mattf/zaptel-1.4-raceandlockingfix/build_tools/zaptel_svn_tarball U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/xpp/.version U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/zaptel-base.c U   team/mattf/zaptel-1.4-raceandlockingfix/kernel/ztdynamic.c ------------------------------------------------------------------------ r4182 | mattf | 2008-06-07 13:59:50 -0500 (Sat, 07 Jun 2008) | 59 lines Merged revisions 4165-4170,4173,4175-4176 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r4165 | tzafrir | 2008-04-10 11:15:23 -0500 (Thu, 10 Apr 2008) | 5 lines Officially bumping xpp version (xpp/.version) to 5566 . Merged revisions 4164 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4166 | tzafrir | 2008-04-10 13:11:51 -0500 (Thu, 10 Apr 2008) | 2 lines zaptel_svn_tarball - get a tarball fron an SVN snapshot. ........ r4167 | sruffell | 2008-04-10 16:01:59 -0500 (Thu, 10 Apr 2008) | 2 lines Fixed typo in makefile which was preventing make from installing the udev rules. ........ r4168 | dbailey | 2008-04-10 17:25:30 -0500 (Thu, 10 Apr 2008) | 3 lines Correct problem where drivers implementing echocan_with_params was not getting called to disable the echo canceller ........ r4169 | mattf | 2008-04-11 16:16:47 -0500 (Fri, 11 Apr 2008) | 1 line Make sure that we disable the echo canceller on the old style echocan() function even if parameters are passed in. ........ r4170 | mattf | 2008-04-11 16:17:55 -0500 (Fri, 11 Apr 2008) | 1 line Take out part of a commit to the wct4xxp driver that wasn't supposed to go in ........ r4173 | kpfleming | 2008-04-17 07:20:26 -0500 (Thu, 17 Apr 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ........ r4175 | tzafrir | 2008-04-17 09:27:50 -0500 (Thu, 17 Apr 2008) | 5 lines Avoid a double-free in ztdynamic.c ztdynamic_chanfree.diff from bug ZAP-308 . Merged revisions 4174 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4176 | jdixon | 2008-04-18 10:19:00 -0500 (Fri, 18 Apr 2008) | 2 lines Fixed monitoring of zap pseudo channels ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=4182 By: Digium Subversion (svnbot) 2008-06-07 14:00:34 Repository: dahdi Revision: 4220 _U  team/mattf/zaptel-1.4-stackcleanup/ U   team/mattf/zaptel-1.4-stackcleanup/Makefile U   team/mattf/zaptel-1.4-stackcleanup/README A   team/mattf/zaptel-1.4-stackcleanup/build_tools/zaptel_svn_tarball U   team/mattf/zaptel-1.4-stackcleanup/kernel/pciradio.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/wctdm.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/.version U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/Kbuild U   team/mattf/zaptel-1.4-stackcleanup/kernel/xpp/utils/zconf/Zaptel/Config/Defaults.pm U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel-base.c U   team/mattf/zaptel-1.4-stackcleanup/kernel/zaptel.h U   team/mattf/zaptel-1.4-stackcleanup/kernel/ztdynamic.c U   team/mattf/zaptel-1.4-stackcleanup/zaptel.init U   team/mattf/zaptel-1.4-stackcleanup/ztcfg.c ------------------------------------------------------------------------ r4220 | mattf | 2008-06-07 14:00:30 -0500 (Sat, 07 Jun 2008) | 143 lines Merged revisions 4165-4170,4173,4175-4176,4183-4185,4187,4190-4196,4213,4217 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r4165 | tzafrir | 2008-04-10 11:15:23 -0500 (Thu, 10 Apr 2008) | 5 lines Officially bumping xpp version (xpp/.version) to 5566 . Merged revisions 4164 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4166 | tzafrir | 2008-04-10 13:11:51 -0500 (Thu, 10 Apr 2008) | 2 lines zaptel_svn_tarball - get a tarball fron an SVN snapshot. ........ r4167 | sruffell | 2008-04-10 16:01:59 -0500 (Thu, 10 Apr 2008) | 2 lines Fixed typo in makefile which was preventing make from installing the udev rules. ........ r4168 | dbailey | 2008-04-10 17:25:30 -0500 (Thu, 10 Apr 2008) | 3 lines Correct problem where drivers implementing echocan_with_params was not getting called to disable the echo canceller ........ r4169 | mattf | 2008-04-11 16:16:47 -0500 (Fri, 11 Apr 2008) | 1 line Make sure that we disable the echo canceller on the old style echocan() function even if parameters are passed in. ........ r4170 | mattf | 2008-04-11 16:17:55 -0500 (Fri, 11 Apr 2008) | 1 line Take out part of a commit to the wct4xxp driver that wasn't supposed to go in ........ r4173 | kpfleming | 2008-04-17 07:20:26 -0500 (Thu, 17 Apr 2008) | 6 lines when processing ZT_SET_DIALPARAMS, don't return an error for out-of-range tone durations, just ignore them (so that applications that don't initialize the entire zt_dialparams structure won't fail to set the ones they do initialize) (closes issue ASTERISK-11861) Reported by: fnordian Tested by: fnordian ........ r4175 | tzafrir | 2008-04-17 09:27:50 -0500 (Thu, 17 Apr 2008) | 5 lines Avoid a double-free in ztdynamic.c ztdynamic_chanfree.diff from bug ZAP-308 . Merged revisions 4174 via svnmerge from http://svn.digium.com/svn/zaptel/branches/1.2 ........ r4176 | jdixon | 2008-04-18 10:19:00 -0500 (Fri, 18 Apr 2008) | 2 lines Fixed monitoring of zap pseudo channels ........ r4183 | mattf | 2008-04-19 16:54:03 -0500 (Sat, 19 Apr 2008) | 1 line Partial fix for DAHLIN-5.  Fixes potential race condition in open and close routines for zaptel devices ........ r4184 | mattf | 2008-04-19 16:56:06 -0500 (Sat, 19 Apr 2008) | 1 line Remove unintentional svn property addition ........ r4185 | mattf | 2008-04-19 17:05:42 -0500 (Sat, 19 Apr 2008) | 1 line Fix compiler from complaining ........ r4187 | tzafrir | 2008-04-21 16:27:59 -0500 (Mon, 21 Apr 2008) | 4 lines Zaptel::Config::Default - don't die if no config file. (Accidentally left out of the merge from 1.2) ........ r4190 | jdixon | 2008-04-22 17:07:08 -0500 (Tue, 22 Apr 2008) | 2 lines Fixed problem preventing multiple channels from using multiple CTCSS ........ r4191 | jdixon | 2008-04-22 23:36:22 -0500 (Tue, 22 Apr 2008) | 2 lines Updated to latest code, fixed bug in serial i/o ........ r4192 | tzafrir | 2008-04-23 04:48:56 -0500 (Wed, 23 Apr 2008) | 2 lines Bumped into yet another incompatibility. ........ r4193 | tzafrir | 2008-04-23 14:20:53 -0500 (Wed, 23 Apr 2008) | 10 lines A test for a specific #define in zconfig.h was done by invoking cpp . Sadly the change of CFLAGS handling in kernel 2.6.24 meant that it is no longer as easy to invoke cpp on our own. Impact: On kernel >= 2.6.24, xpd_bri never got built, even if the bri_dchan patch was applied. Fix: use a simpler grep instead. Hopefully noone passes it through other means. This should hopfully fix issue ZAP-312 . ........ r4194 | sruffell | 2008-04-24 13:17:12 -0500 (Thu, 24 Apr 2008) | 5 lines Fixes a regression in versions 1.2.25 and 1.4.19 identified by korihor where the wctdm driver was no longer properly recognizing polarity reversals. (closes issue ZAP-309) ........ r4195 | qwell | 2008-04-25 13:10:06 -0500 (Fri, 25 Apr 2008) | 1 line Based on a comment made by moy in #asterisk-dev, and the surrounding code in these functions, I believe that this is what was actually intended in r4130. ........ r4196 | qwell | 2008-04-25 15:47:07 -0500 (Fri, 25 Apr 2008) | 7 lines Since MF R2 tones are generated continuously, we need to not set the dialing status. (closes issue ZAP-317) Reported by: moy Patches:      zaptel-mf-dialing-rev4195.patch uploaded by moy (license 222) ........ r4213 | twilson | 2008-05-01 11:46:44 -0500 (Thu, 01 May 2008) | 2 lines Allow $(ARCH) to be overridden and pass on through $(KMAKE) ........ r4217 | qwell | 2008-05-01 14:37:07 -0500 (Thu, 01 May 2008) | 7 lines Clarify a message.  Some hardware doesn't provide timing, so this could be confusing. (closes issue ZAP-313) Reported by: panderson Patches:      zaptel.init.patch uploaded by panderson (license 469) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=4220