Summary:	ASTERISK-11851: Autofill does not work from general section for realtime queues
Reporter:	Atis Lezdins (atis)	Labels:
Date Opened:	2008-04-15 04:53:23	Date Closed:	2010-08-18 12:21:03
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 12445-autofill.diff
Description:	When adding `autofill` column set to 1 to realtime queues, it magically starts working. So either documentation (configs/queues.conf.sample) or app_queue needs to be fixed. queues.conf: [general] persistentmembers = yes autofill=yes realtime_family = queues,queue_members
Comments:	By: Jason Parker (jparker) 2008-04-15 10:22:02 On line 825 of app_queue.c, there is a line q->autofill = 0; that I'm pretty sure is causing this.  Can you try removing that and recompiling?  If you need a patch, I can go ahead and make one.  Let me know. By: Atis Lezdins (atis) 2008-04-15 10:39:33 weird - when i saw those two lines i was confident that it's a trivial bug and it should help, but seems it doesn't. i'll do some more testing tomorrow and play with that. By: Mark Michelson (mmichelson) 2008-04-15 11:04:06 That line setting q->autofill to 0 is to make sure that autofill is set to the default value (although it is actually done earlier in the queue initialization function, so that line is redundant) but that should not affect the final setting of autofill. If I understand what the report is saying, you're saying that setting autofill=yes in the general section does not work. This is expected, and if the documentation says otherwise, then it should be updated. By: Digium Subversion (svnbot) 2008-04-15 11:13:03 Repository: asterisk Revision: 114133 U   branches/1.4/apps/app_queue.c ------------------------------------------------------------------------ r114133 | qwell | 2008-04-15 11:13:02 -0500 (Tue, 15 Apr 2008) | 8 lines Allow autofill to work in the general section of queues.conf. Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value). (closes issue ASTERISK-11851) Reported by: atis Patches:      12445-autofill.diff uploaded by qwell (license 4) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114133 By: Digium Subversion (svnbot) 2008-04-15 11:13:40 Repository: asterisk Revision: 114134 _U  trunk/ U   trunk/apps/app_queue.c ------------------------------------------------------------------------ r114134 | qwell | 2008-04-15 11:13:39 -0500 (Tue, 15 Apr 2008) | 16 lines Merged revisions 114133 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114133 | qwell | 2008-04-15 11:18:08 -0500 (Tue, 15 Apr 2008) | 8 lines Allow autofill to work in the general section of queues.conf. Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value). (closes issue ASTERISK-11851) Reported by: atis Patches:      12445-autofill.diff uploaded by qwell (license 4) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114134 By: Digium Subversion (svnbot) 2008-04-15 11:13:59 Repository: asterisk Revision: 114135 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_queue.c ------------------------------------------------------------------------ r114135 | qwell | 2008-04-15 11:13:59 -0500 (Tue, 15 Apr 2008) | 24 lines Merged revisions 114134 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114134 | qwell | 2008-04-15 11:18:38 -0500 (Tue, 15 Apr 2008) | 16 lines Merged revisions 114133 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114133 | qwell | 2008-04-15 11:18:08 -0500 (Tue, 15 Apr 2008) | 8 lines Allow autofill to work in the general section of queues.conf. Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value). (closes issue ASTERISK-11851) Reported by: atis Patches:      12445-autofill.diff uploaded by qwell (license 4) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114135