| Summary: | ASTERISK-11844: [patch] Asterisk throws warnings about not being able to update the user's LDAP record when it's actually successful | ||
| Reporter: | Gonzalo Servat (gservat) | Labels: | |
| Date Opened: | 2008-04-14 09:09:20 | Date Closed: | 2008-04-21 11:58:51 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Resources/res_config_ldap |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) res_config_ldap.c-patch-code | |
| Description: | Hi, (this actually applies to the latest beta 1.6.0-beta7.1, however, it's not in the Asterisk version list) I see the following error in the Asterisk console every few seconds: [Apr 14 10:55:10] ERROR[27318]: res_config_ldap.c:1289 update_ldap: Couldn't modify dn:cn=gservat,dc=example,dc=com because Success ****** ADDITIONAL INFORMATION ****** Notice the "Success" part. I looked at the res_config_ldap.c source where this msg gets produced (line 1289) and it seems that the ldap_modify_ext_s call (line 1288) returns 0 on success. I'll attach a patch which fixes this issue. Please check if it's correct. Thanks | ||
| Comments: | By: Joshua C. Colp (jcolp) 2008-04-14 09:12:51 We can not look at patches until they are properly licensed. Please follow the procedure and then attach your patch. By: Gonzalo Servat (gservat) 2008-04-14 09:15:35 Hi file, Sorry about that. I forgot to tick the 'Check if this is a code or documentation submission' checkbox (first time posting a patch to Digium). I've signed the license, so we're just waiting for Digium to verify and accept. By: Gonzalo Servat (gservat) 2008-04-20 14:15:19 Any news on this? By: Digium Subversion (svnbot) 2008-04-21 09:29:12 Repository: asterisk Revision: 114320 U trunk/res/res_config_ldap.c ------------------------------------------------------------------------ r114320 | file | 2008-04-21 09:29:08 -0500 (Mon, 21 Apr 2008) | 6 lines Only print out the error message if ldap_modify_ext_s actually returns an error, and not success. (closes issue ASTERISK-11844) Reported by: gservat Patches: res_config_ldap.c-patch-code uploaded by gservat (license 466) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114320 By: Digium Subversion (svnbot) 2008-04-21 09:30:45 Repository: asterisk Revision: 114321 _U branches/1.6.0/ U branches/1.6.0/res/res_config_ldap.c ------------------------------------------------------------------------ r114321 | file | 2008-04-21 09:30:44 -0500 (Mon, 21 Apr 2008) | 14 lines Merged revisions 114320 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r114320 | file | 2008-04-21 11:34:06 -0300 (Mon, 21 Apr 2008) | 6 lines Only print out the error message if ldap_modify_ext_s actually returns an error, and not success. (closes issue ASTERISK-11844) Reported by: gservat Patches: res_config_ldap.c-patch-code uploaded by gservat (license 466) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114321 By: Digium Subversion (svnbot) 2008-04-21 11:58:51 Repository: asterisk Revision: 114334 _U team/seanbright/resolve-shadow-warnings/ U team/seanbright/resolve-shadow-warnings/apps/app_authenticate.c U team/seanbright/resolve-shadow-warnings/channels/chan_sip.c U team/seanbright/resolve-shadow-warnings/doc/janitor-projects.txt U team/seanbright/resolve-shadow-warnings/res/res_config_ldap.c ------------------------------------------------------------------------ r114334 | seanbright | 2008-04-21 11:58:49 -0500 (Mon, 21 Apr 2008) | 39 lines Merged revisions 114320,114323,114325,114327 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r114320 | file | 2008-04-21 10:34:06 -0400 (Mon, 21 Apr 2008) | 6 lines Only print out the error message if ldap_modify_ext_s actually returns an error, and not success. (closes issue ASTERISK-11844) Reported by: gservat Patches: res_config_ldap.c-patch-code uploaded by gservat (license 466) ................ r114323 | file | 2008-04-21 10:40:33 -0400 (Mon, 21 Apr 2008) | 12 lines Merged revisions 114322 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114322 | file | 2008-04-21 11:39:32 -0300 (Mon, 21 Apr 2008) | 4 lines Only drop audio if we receive it without a progress indication. We allow other frames through such as DTMF because they may be needed to complete the call. (closes issue ASTERISK-11846) Reported by: aragon ........ ................ r114325 | russell | 2008-04-21 11:01:04 -0400 (Mon, 21 Apr 2008) | 2 lines Add a simple janitor project ................ r114327 | jpeeler | 2008-04-21 11:34:37 -0400 (Mon, 21 Apr 2008) | 2 lines This removes an invalid warning message for an incorrectly entered pin, but more importantly removes an inapplicable check. If the first argument passed to app_authenticate does not contain a '/', the argument should be treated as the sole fixed "password" to match against and that is all. (Previous behavior was attempting to open a file based on the pin.) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=114334 | ||