[Home]

Summary:ASTERISK-11814: [patch] Added functionality to astcli
Reporter:David Van Ginneken (davevg)Labels:
Date Opened:2008-04-09 20:20:45Date Closed:2008-04-11 16:14:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Utilities/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) astcli
( 1) astcli.diff
( 2) astcli.diff2
Description:Replaced Net::Telnet dependency with IO::Socket, added additional -i parameter for interactive mode.
Comments:By: David Van Ginneken (davevg) 2008-04-10 10:27:14

I thought about this some more today.  I don't think we want the option to be i, but r instead, so it sort of simulates what asterisk -r does.  Then change the if ($action eq '-') clause to also go into the "terminal" if there are no actions sent on the command line.
By: Tilghman Lesher (tilghman) 2008-04-10 13:08:32

If it's going to default to interactive mode, why have an option flag at all?
By: David Van Ginneken (davevg) 2008-04-10 13:11:22

If you don't pass -r, it won't be in interactive mode.  So passing commands in on STDIN would still work.

patch the existing version with the last patch, then run ./astcli -r and then run ./astcli -  to see the difference.
By: David Van Ginneken (davevg) 2008-04-10 13:52:40

To clarify, interactive is being defaulted to 0 in this line:

my ($user, $pw, $host, $port, $interactive) = (undef, undef, 'localhost', 5038, 0);

It is only enabled if you pass the -r, and even if you pass the -r it can only go into that mode if it passes the eval for the perl dependancy.

eval { require Term::ReadLine;};
$interactive = ($@?0:1);

Which sets it to disabled and prints a message to STDERR if the require fails.
By: Digium Subversion (svnbot) 2008-04-10 13:59:44

Repository: asterisk
Revision: 114042

U   trunk/contrib/scripts/astcli

------------------------------------------------------------------------
r114042 | tilghman | 2008-04-10 13:59:39 -0500 (Thu, 10 Apr 2008) | 7 lines

The hydra grows yet another head...
(closes issue ASTERISK-11814)
Reported by: davevg
Patches:
      astcli.diff2 uploaded by davevg (license 209)
Tested by: davevg, Corydon76

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114042
By: Digium Subversion (svnbot) 2008-04-10 14:04:52

Repository: asterisk
Revision: 114043

_U  branches/1.6.0/
U   branches/1.6.0/contrib/scripts/astcli

------------------------------------------------------------------------
r114043 | tilghman | 2008-04-10 14:04:51 -0500 (Thu, 10 Apr 2008) | 15 lines

Merged revisions 114042 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r114042 | tilghman | 2008-04-10 14:04:29 -0500 (Thu, 10 Apr 2008) | 7 lines

The hydra grows yet another head...
(closes issue ASTERISK-11814)
Reported by: davevg
Patches:
      astcli.diff2 uploaded by davevg (license 209)
Tested by: davevg, Corydon76

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114043
By: Digium Subversion (svnbot) 2008-04-11 16:14:06

Repository: asterisk
Revision: 114070

_U  team/murf/bug11210/
U   team/murf/bug11210/CHANGES
U   team/murf/bug11210/channels/chan_local.c
U   team/murf/bug11210/channels/chan_sip.c
U   team/murf/bug11210/contrib/scripts/astcli
U   team/murf/bug11210/include/asterisk/lock.h
U   team/murf/bug11210/main/features.c
U   team/murf/bug11210/main/manager.c
U   team/murf/bug11210/main/utils.c
U   team/murf/bug11210/res/res_config_ldap.c
U   team/murf/bug11210/res/res_phoneprov.c
U   team/murf/bug11210/utils/Makefile
U   team/murf/bug11210/utils/ael_main.c
U   team/murf/bug11210/utils/astman.c
U   team/murf/bug11210/utils/check_expr.c
U   team/murf/bug11210/utils/conf2ael.c
U   team/murf/bug11210/utils/hashtest.c
U   team/murf/bug11210/utils/hashtest2.c

------------------------------------------------------------------------
r114070 | murf | 2008-04-11 16:14:03 -0500 (Fri, 11 Apr 2008) | 80 lines

Merged revisions 114042-114069 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r114042 | tilghman | 2008-04-10 13:04:29 -0600 (Thu, 10 Apr 2008) | 7 lines
 
 The hydra grows yet another head...
 (closes issue ASTERISK-11814)
  Reported by: davevg
  Patches:
        astcli.diff2 uploaded by davevg (license 209)
  Tested by: davevg, Corydon76
................
 r114046 | mmichelson | 2008-04-10 13:58:36 -0600 (Thu, 10 Apr 2008) | 14 lines
 
 Merged revisions 114045 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
 r114045 | mmichelson | 2008-04-10 14:55:33 -0500 (Thu, 10 Apr 2008) | 6 lines
 
 Be sure that we're not about to set bridgepvt NULL prior to dereferencing it.
 
 (closes issue ASTERISK-11244)
 Reported by: fujin
 
 
 ........
................
 r114049 | file | 2008-04-10 14:28:40 -0600 (Thu, 10 Apr 2008) | 2 lines
 
 A 'b' option has been added which causes chan_local to return the actual channel that is behind it when queried. This is useful for transfer scenarios as the actual channel will be transferred, not the Local channel. If you have been using Local channels as queue members and having issues when the agent did a blind transfer this option may solve the issue.
................
 r114052 | mmichelson | 2008-04-10 16:02:32 -0600 (Thu, 10 Apr 2008) | 11 lines
 
 Merged revisions 114051 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
 r114051 | mmichelson | 2008-04-10 15:59:49 -0500 (Thu, 10 Apr 2008) | 3 lines
 
 Fix 1.4 build when LOW_MEMORY is enabled.
 
 
 ........
................
 r114061 | tilghman | 2008-04-11 08:54:22 -0600 (Fri, 11 Apr 2008) | 6 lines
 
 Errors are all greater than 0
 (closes issue ASTERISK-11831)
  Reported by: nito
  Patches:
        res_config_ldap_result_check_patch.diff uploaded by nito (license 340)
................
 r114064 | mmichelson | 2008-04-11 09:49:35 -0600 (Fri, 11 Apr 2008) | 19 lines
 
 Merged revisions 114063 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
 r114063 | mmichelson | 2008-04-11 10:44:28 -0500 (Fri, 11 Apr 2008) | 11 lines
 
 Fix a race condition that may happen between a sip hangup
 and a "core show channel" command. This patch adds locking
 to prevent the resulting crash.
 
 (closes issue ASTERISK-11586)
 Reported by: tsearle
 Patches:
       show_channels_crash2.patch uploaded by tsearle (license 373)
 Tested by: tsearle
 
 
 ........
................
 r114067 | twilson | 2008-04-11 15:04:46 -0600 (Fri, 11 Apr 2008) | 3 lines
 
 Fix the fact that global_variables 1) weren't being updated on reload (thanks for the report, Doug), and 2) weren't actually being appended to the list of profile variables because build_profile was called before the list was populated. Also needed to free the contents returned by load_file().
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114070