[Home]

Summary:ASTERISK-11811: [patch] : support for new Nortel i2050 softphone
Reporter:c_hans (c_hans)Labels:
Date Opened:2008-04-09 13:57:01Date Closed:2008-04-15 12:17:23
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_unistim
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_unistim_svn.diff
( 1) chan_unistim.diff
Description:New i2050 softphone send a different hardware address (0x3132 instead of 0x3138).
Bug reported by Tom Cross of X-Force Research / IBM Internet Security Systems
Thank you.
Comments:By: Jason Parker (jparker) 2008-04-11 10:40:53

You will need to reupload the patch after submitting a new license agreement.
By: Jason Parker (jparker) 2008-04-11 17:54:13

Either I'm misreading this code, or it's incorrect.  Wouldn't the MAC address start after the 0x31, 0x38?
By: c_hans (c_hans) 2008-04-15 11:02:58

Yes, the MAC address is still after these two bytes.
The Wireshark source only tell us
0x9a Basic Manager Phone
0x07 Hardware ID

Maybe 0x31 0x32/38 report a version or some hardware identification.
Anyway, the code parsing the mac address use a fixed position. packet_recv_mac_addr is only used to classify the packet. We now just ignore these two bytes.
By: Digium Subversion (svnbot) 2008-04-15 12:16:58

Repository: asterisk
Revision: 114141

U   trunk/channels/chan_unistim.c

------------------------------------------------------------------------
r114141 | qwell | 2008-04-15 12:16:56 -0500 (Tue, 15 Apr 2008) | 8 lines

Shorten the mac address pattern, since some phones use different identifiers (such as the i2050 softphone).

(closes issue ASTERISK-11811)
Reported by: c_hans
Patches:
     chan_unistim_svn.diff uploaded by c (license 460)
Tested by: c_hans

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114141
By: Digium Subversion (svnbot) 2008-04-15 12:17:23

Repository: asterisk
Revision: 114142

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_unistim.c

------------------------------------------------------------------------
r114142 | qwell | 2008-04-15 12:17:22 -0500 (Tue, 15 Apr 2008) | 16 lines

Merged revisions 114141 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r114141 | qwell | 2008-04-15 12:21:58 -0500 (Tue, 15 Apr 2008) | 8 lines

Shorten the mac address pattern, since some phones use different identifiers (such as the i2050 softphone).

(closes issue ASTERISK-11811)
Reported by: c_hans
Patches:
     chan_unistim_svn.diff uploaded by c (license 460)
Tested by: c_hans

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114142