| Summary: | ASTERISK-11804: [patch] some fixes to astcli | ||
| Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
| Date Opened: | 2008-04-09 01:54:50 | Date Closed: | 2008-04-09 08:20:02 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) astcli_fixes.diff | |
| Description: | A number of fixes to astcli: 1. the script lacks a license terms stanza. 2. The script will die if a certain configuration file does not exist. So I can't just copy it to a system and use it. If I don't happen to have write permissions to /etc/asterisk I can't use it at all. Fix: don't die. Just ignore that file. 3. Configuration file names under /etc should not be hidden . The reason configuration files under the home directory are hidden are to avoid cluttering it. But in /etc configuration files are not a clutter. Think of the sysadmin who is used to backup his /etc/asterisk using 'cp -a /etc/asterisk/* /target/dir/' Fix: Change the global configuration file name to /etc/asterisk/astcli.conf . However: A. This file does not follow the syntax of Asterisk's configuration files (no [header]) B. We already have /etc/asterisk/asterisk-cli.conf 3. The script has useful output. Thus the help text should go to standard error. 4. Parse global config first, user config later and then command-line arguments. And while we're at it, allow commands from standard input. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-04-09 08:18:53 Repository: asterisk Revision: 113647 U trunk/contrib/scripts/astcli ------------------------------------------------------------------------ r113647 | tilghman | 2008-04-09 08:18:51 -0500 (Wed, 09 Apr 2008) | 6 lines Additional enhancements (closes issue ASTERISK-11804) Reported by: tzafrir Patches: astcli_fixes.diff uploaded by tzafrir (license 46) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113647 By: Digium Subversion (svnbot) 2008-04-09 08:20:02 Repository: asterisk Revision: 113648 _U branches/1.6.0/ U branches/1.6.0/contrib/scripts/astcli ------------------------------------------------------------------------ r113648 | tilghman | 2008-04-09 08:20:02 -0500 (Wed, 09 Apr 2008) | 14 lines Merged revisions 113647 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r113647 | tilghman | 2008-04-09 08:23:44 -0500 (Wed, 09 Apr 2008) | 6 lines Additional enhancements (closes issue ASTERISK-11804) Reported by: tzafrir Patches: astcli_fixes.diff uploaded by tzafrir (license 46) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113648 | ||