Summary:ASTERISK-11779: [patch] downloaded iLBC code yields warning on compilation; halts dev-mode builds
Reporter:Steve Murphy (murf)Labels:
Date Opened:2008-04-03 13:12:22Date Closed:2008-04-22 13:48:19
Versions:Frequency of
Environment:Attachments:( 0) ilbcfix
Description:on a 64-bit platform, I see:

cc1: warnings being treated as errors
iCBSearch.c: In function ‘iCBSearch’:
iCBSearch.c:130: warning: operation on ‘pp’ may be undefined
iCBSearch.c:325: warning: operation on ‘pp’ may be undefined
make[2]: *** [iCBSearch.o] Error 1
make[2]: Leaving directory `/home/murf/asterisk/bug11210/codecs/ilbc'
make[1]: *** [ilbc/libilbc.a] Error 2
make[1]: Leaving directory `/home/murf/asterisk/bug11210/codecs'
make: *** [codecs] Error 2
Comments:By: Steve Murphy (murf) 2008-04-03 13:19:34

I've attached a patch  I believe will solve the problem. At least, things compile without warning with it applied.

Since iLBC is external to Asterisk, I thought I'd just make sure that this kind of patch is OK before committing it. It does mention about a dozen characters in the source. I personally don't think the snippet is long enough to violate anybody's licenses, but it never hurts to be sure.

By: Steve Murphy (murf) 2008-04-03 13:25:30

Oh, and also, using sed is magic... if they sometime correct this problem, then the script won't change anything, when the pattern doesn't match any more, and no action will be taken. Thus, we don't have to worry about it breaking if they change the source.

By: Steve Murphy (murf) 2008-04-22 13:48:19

KpFleming says not to do anything with this; they are making arrangements and soon will have a solution. In the meantime, uncheck ilbc in the make menuselect format list and get on with life.