[Home]

Summary:ASTERISK-11760: more code documentation
Reporter:Travis Hein (travishein)Labels:
Date Opened:2008-03-31 12:18:22Date Closed:2008-04-01 13:24:05
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail_code_convention.patch
( 1) app_voicemail_code_documentation.patch
( 2) app_voicemail_documentation.patch
Description:Mostly adding doxygen code documentation tags.

A couple places where adjustments to adhere to code conventions as well (remove braces for single line if-else)
Comments:By: Jason Parker (jparker) 2008-03-31 12:23:29

It would be highly preferred if these patches could be split into documentation additions and code changes (unless they are very related).

Would you be willing to do that here?
By: Travis Hein (travishein) 2008-03-31 12:55:17

Of course. That makes perfect sense.

Please ignore the first (app_voicemail_documentation.patch) one

and instead, see the attached are separate patches.

the app_voicemail_code_documentation.patch is the comments only.
the app_voicemail_code_convention.patch is the small code changes with brace and variable declarations.


By: Digium Subversion (svnbot) 2008-04-01 13:20:34

Repository: asterisk
Revision: 112241

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r112241 | qwell | 2008-04-01 13:20:33 -0500 (Tue, 01 Apr 2008) | 7 lines

More voicemail doxygen additions/cleanup.

(issue ASTERISK-11760)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112241
By: Digium Subversion (svnbot) 2008-04-01 13:22:39

Repository: asterisk
Revision: 112252

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r112252 | qwell | 2008-04-01 13:22:38 -0500 (Tue, 01 Apr 2008) | 7 lines

Minor formatting cleanup.

(closes issue ASTERISK-11760)
Reported by: travishein
Patches:
     app_voicemail_code_convention.patch uploaded by travishein (license 385)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112252
By: Digium Subversion (svnbot) 2008-04-01 13:23:34

Repository: asterisk
Revision: 112256

_U  branches/1.6.0/

------------------------------------------------------------------------
r112256 | qwell | 2008-04-01 13:23:33 -0500 (Tue, 01 Apr 2008) | 14 lines

Blocked revisions 112252 via svnmerge

........
r112252 | qwell | 2008-04-01 13:27:08 -0500 (Tue, 01 Apr 2008) | 7 lines

Minor formatting cleanup.

(closes issue ASTERISK-11760)
Reported by: travishein
Patches:
     app_voicemail_code_convention.patch uploaded by travishein (license 385)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112256
By: Digium Subversion (svnbot) 2008-04-01 13:24:05

Repository: asterisk
Revision: 112259

_U  branches/1.6.0/

------------------------------------------------------------------------
r112259 | qwell | 2008-04-01 13:24:04 -0500 (Tue, 01 Apr 2008) | 14 lines

Blocked revisions 112241 via svnmerge

........
r112241 | qwell | 2008-04-01 13:24:56 -0500 (Tue, 01 Apr 2008) | 7 lines

More voicemail doxygen additions/cleanup.

(issue ASTERISK-11760)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112259