[Home]

Summary:ASTERISK-11753: DSP_FEATURE_DTMF_DETECT issues in asterisk 1.6 and asterisk-addons 1.6
Reporter:Ovidiu Sas (ovi)Labels:
Date Opened:2008-03-30 08:15:32Date Closed:2008-03-31 17:13:24
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Addons/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 12334-asterisk.patch
Description:DSP_FEATURE_DTMF_DETECT used to be defined in:
./include/asterisk/dsp.h:#define DSP_FEATURE_DTMF_DETECT                (1 << 3)

Not it is gone, however, it is still used in:
./channels/chan_usbradio.c:             ast_dsp_set_features(o->dsp, DSP_FEATURE_DTMF_DETECT);

Also, asterisk-addons doesn't compile anymore because of this.

****** ADDITIONAL INFORMATION ******

It seems that this issue is related to:
2008-03-19 22:25 +0000 [r110132-110161]  Jason Parker <jparker@digium.com>

       * channels/chan_misdn.c, channels/chan_zap.c, channels/chan_sip.c,
         channels/chan_h323.c, include/asterisk/dsp.h,
         channels/chan_mgcp.c, main/dsp.c: Rename DSP_FEATURE_DTMF_DETECT,
         because we are *NOT* only detecting DTMF digits. This was very
         misleading. Early cleanup for issue ASTERISK-11413

       * channels/chan_usbradio.c, channels/chan_vpb.cc,
         channels/chan_zap.c, channels/chan_sip.c, include/asterisk/dsp.h,
         channels/chan_mgcp.c, main/dsp.c: Rename very poorly named
         function to reflect what it actually does. This was causing quite
         a bit of confusion for me...
Comments:By: Dmitry Andrianov (dimas) 2008-03-30 09:19:27

Well, patch for the Asterisk is very simple (attached).

However I can not find what is wrong with addons - it does not have references to renamed stuff and it compiles fine on my machine...
By: Ovidiu Sas (ovi) 2008-03-30 09:40:07

I was referring to asterisk-addons beta2.
Maybe asterisk-addons beta3 should be released.
By: Jason Parker (jparker) 2008-03-31 10:18:32

Yes, we need to get the versioning for asterisk-addons ironed out.  I am going to push for a beta3 release later today.
By: Digium Subversion (svnbot) 2008-03-31 17:11:56

Repository: asterisk
Revision: 112071

U   trunk/channels/chan_usbradio.c

------------------------------------------------------------------------
r112071 | qwell | 2008-03-31 17:11:55 -0500 (Mon, 31 Mar 2008) | 7 lines

I missed a place when this define was changed.

(closes issue ASTERISK-11753)
Reported by: ovi
Patches:
     12334-asterisk.patch uploaded by dimas (license 88)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112071
By: Digium Subversion (svnbot) 2008-03-31 17:13:24

Repository: asterisk
Revision: 112072

_U  branches/1.6.0/

------------------------------------------------------------------------
r112072 | qwell | 2008-03-31 17:13:23 -0500 (Mon, 31 Mar 2008) | 14 lines

Blocked revisions 112071 via svnmerge

........
r112071 | qwell | 2008-03-31 17:16:34 -0500 (Mon, 31 Mar 2008) | 7 lines

I missed a place when this define was changed.

(closes issue ASTERISK-11753)
Reported by: ovi
Patches:
     12334-asterisk.patch uploaded by dimas (license 88)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=112072