[Home]

Summary:ASTERISK-11747: [patch] code documentation
Reporter:Travis Hein (travishein)Labels:
Date Opened:2008-03-28 13:47:00Date Closed:2008-03-28 14:06:50
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail_code_documentation.patch
Description:Added some doxygen function documentation comments in our coding style.
Comments:By: Travis Hein (travishein) 2008-03-28 13:50:26

Also did some small cleanup, to extract constant

#define VMSTATE_MAX_MSG_ARRAY 256

and to use that everywhere for vm_state->msgArray[] instead of "256".
By: Jason Parker (jparker) 2008-03-28 13:59:23

Excellent!  Random documentation is always good.

I'm going to go ahead and split this into two commits, just for sanities sake.
By: Digium Subversion (svnbot) 2008-03-28 14:02:25

Repository: asterisk
Revision: 111773

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r111773 | qwell | 2008-03-28 14:02:22 -0500 (Fri, 28 Mar 2008) | 7 lines

Add a bit of doxygen documentation for app_voicemail.

(issue ASTERISK-11747)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=111773
By: Digium Subversion (svnbot) 2008-03-28 14:04:11

Repository: asterisk
Revision: 111774

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r111774 | qwell | 2008-03-28 14:04:10 -0500 (Fri, 28 Mar 2008) | 8 lines

Replace magic number size from msgArray array with a define.

(same patch as before, I just split this part out)
(close issue ASTERISK-11747)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=111774
By: Digium Subversion (svnbot) 2008-03-28 14:06:50

Repository: asterisk
Revision: 111776

_U  branches/1.6.0/

------------------------------------------------------------------------
r111776 | qwell | 2008-03-28 14:06:49 -0500 (Fri, 28 Mar 2008) | 25 lines

Blocked revisions 111773-111774 via svnmerge

........
r111773 | qwell | 2008-03-28 14:06:54 -0500 (Fri, 28 Mar 2008) | 7 lines

Add a bit of doxygen documentation for app_voicemail.

(issue ASTERISK-11747)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

........
r111774 | qwell | 2008-03-28 14:08:35 -0500 (Fri, 28 Mar 2008) | 8 lines

Replace magic number size from msgArray array with a define.

(same patch as before, I just split this part out)
(close issue ASTERISK-11747)
Reported by: travishein
Patches:
     app_voicemail_code_documentation.patch uploaded by travishein (license 385)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=111776