[Home]

Summary:ASTERISK-11708: [patch] Permit 'not null' fields to always be set
Reporter:capouch (capouch)Labels:
Date Opened:2008-03-23 22:47:11Date Closed:2008-04-11 18:22:44
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_pgsql
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080323__cdr_pgsql.diff.txt
( 1) 20080324__cdr_pgsql.diff.txt
Description:Brian Capouch writes, via the -dev list:

I haven't built trunk for a while but tonight I took it up again.

The code builds fine against openWRT, but there seem to be some changes
to the way that CDR works.  I use Postgres to store CDR records.  I
can't find mention of the things mentioned below in CHANGES, in any of
the documentation I could find online, or in the sample configs.

First, it appears that calldate is no longer allowed as a field name in
the table which will hold the CDR record.  I couldn't get it to work
unless I set the field name to "start."

There has also been a change in that the fields "accountcode" and
"userfield" aren't being sent to the backend anymore.  This violates the
"NOT NULL" constraints on those fields that permeate the documentation
everywhere online.

I may have missed some critical information along the line, but if not,
the codebase and existing documentation seem to be out of sync.
Comments:By: Tilghman Lesher (tilghman) 2008-03-24 17:16:20

New patch uploaded.  Slightly mo' bettah.

By: Digium Subversion (svnbot) 2008-04-11 18:22:07

Repository: asterisk
Revision: 114090

U   trunk/cdr/cdr_pgsql.c

------------------------------------------------------------------------
r114090 | tilghman | 2008-04-11 18:22:06 -0500 (Fri, 11 Apr 2008) | 3 lines

If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue ASTERISK-11708)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114090

By: Digium Subversion (svnbot) 2008-04-11 18:22:44

Repository: asterisk
Revision: 114091

_U  branches/1.6.0/
U   branches/1.6.0/cdr/cdr_pgsql.c

------------------------------------------------------------------------
r114091 | tilghman | 2008-04-11 18:22:44 -0500 (Fri, 11 Apr 2008) | 11 lines

Merged revisions 114090 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r114090 | tilghman | 2008-04-11 18:26:56 -0500 (Fri, 11 Apr 2008) | 3 lines

If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue ASTERISK-11708)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114091