[Home]

Summary:ASTERISK-11699: hanguponpolarityswitch ignored because I am not using answeronpolarityswitch
Reporter:Ben Brown (benbrown)Labels:
Date Opened:2008-03-22 07:55:42Date Closed:2011-06-07 14:07:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:As you can see from the debug below I am using hanguponpolarityswitch but not answeronpolarityswitch.

However, the hangup polarity detection is being ignored, I believe, because p->polaritydelaytv is not being initialised and calculating the large negative delay.

Perhaps line 4478 should read:

if ((p->answeronpolarityswitch) && (ast_tvdiff_ms(ast_tvnow(), p->polaritydelaytv) > p->polarityonanswerdelay)) {


****** ADDITIONAL INFORMATION ******

[Mar 22 12:54:01] DEBUG[31186]: chan_zap.c:4478 zt_handle_event: Polarity Reversal event occured - DEBUG 1: channel 4, state 4, pol= 1, aonp= 0, honp= 1, pdelay= 600, tv= -695368355
[Mar 22 12:54:01] DEBUG[31186]: chan_zap.c:4485 zt_handle_event: Polarity Reversal detected but NOT hanging up (too close to answer event) on channel 4, state 4
[Mar 22 12:54:01] DEBUG[31186]: chan_zap.c:4492 zt_handle_event: Polarity Reversal event occured - DEBUG 2: channel 4, state 4, pol= 1, aonp= 0, honp= 1, pdelay= 600, tv= -695368354
Comments:By: Jason Parker (jparker) 2008-05-06 15:29:05

If you have a patch that you've tested, it would be useful for you to upload it here, so we can review it and potentially commit.

By: snuffy (snuffy) 2008-08-22 09:59:23

Do you have any update to report on this benbrown?
Possible code upload?

By: Ben Brown (benbrown) 2008-09-06 18:51:13

Please close this issue, it is no longer present in Asterisk 1.4.21.2.

By: snuffy (snuffy) 2008-09-07 21:03:34

Closed on reporters request.