Summary:	ASTERISK-11679: [patch] [sound] New feature for voicemail to wrap back to last or forward to first message
Reporter:	Andrew Lindh (andrew)	Labels:
Date Opened:	2008-03-18 15:36:05	Date Closed:	2008-04-09 11:20:40
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) bug-12253.diff ( 1) vm14.patch ( 2) vm-goingtofirst.wav ( 3) vm-goingtolast.wav
Description:	I have an old PBX VM system that allowed me to wrap around during voicemail message selection. At the first message I am able to select "previous" and have it jump back to the last message (so I could keep playing them in reverse order). Similar for the last message, it allows me to select "next" and it will jump to the first message. This does not force a change to the order of playback it just allows you to go in a circle to get the message you want quickly. This new feature is enabled by default but can be disabled in the voicemail.conf file. The system knows if there are no messages, or just one, and does not play the prompts for prev/next since it's pointless. ****** ADDITIONAL INFORMATION ****** This patch is for Branch 1.4. I will upload the SVN/Trunk image shortly (after I look at the new code some more). Included english audio files are not correctly licensed for distribution with asterisk and should be re-recorded to match the other asterisk prompts anyway. vm-goingtofirst.wav "Going to the first message." vm-goingtolast.wav "Going to the last message." Copy WAV files to /var/lib/asterisk/sounds (and transcode as needed). Copy patch to main asterisk source directory and run "patch -p0 <vm.patch" and rebuild.
Comments:	By: snuffy (snuffy) 2008-04-09 09:12:49 Updated patch to be compliant with trunk By: Tilghman Lesher (tilghman) 2008-04-09 10:38:08 Actually, the default should be "no", as the option changes how Voicemail works.  Defaults should always lean towards providing identical functionality as before (principle of least surprise). By: Tilghman Lesher (tilghman) 2008-04-09 10:42:36 And... I don't really see the need for these new prompts.  The envelope already plays "First message" and "Last message", on the corresponding messages, so we already have audio prompts that distinguish when you're looping around. By: Digium Subversion (svnbot) 2008-04-09 11:12:04 Repository: asterisk Revision: 113731 U   trunk/apps/app_voicemail.c U   trunk/configs/voicemail.conf.sample ------------------------------------------------------------------------ r113731 | tilghman | 2008-04-09 11:11:58 -0500 (Wed, 09 Apr 2008) | 6 lines Permit message wrap-around during message retrieval. (closes issue ASTERISK-11679) Reported by: andrew Patches:       bug-12253.diff uploaded by snuffy (license 35) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113731 By: Digium Subversion (svnbot) 2008-04-09 11:13:26 Repository: asterisk Revision: 113732 _U  branches/1.6.0/ ------------------------------------------------------------------------ r113732 | tilghman | 2008-04-09 11:13:24 -0500 (Wed, 09 Apr 2008) | 13 lines Blocked revisions 113731 via svnmerge ........ r113731 | tilghman | 2008-04-09 11:16:44 -0500 (Wed, 09 Apr 2008) | 6 lines Permit message wrap-around during message retrieval. (closes issue ASTERISK-11679) Reported by: andrew Patches:       bug-12253.diff uploaded by snuffy (license 35) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113732 By: Digium Subversion (svnbot) 2008-04-09 11:19:23 Repository: asterisk Revision: 113752 U   trunk/CHANGES ------------------------------------------------------------------------ r113752 | tilghman | 2008-04-09 11:19:21 -0500 (Wed, 09 Apr 2008) | 2 lines Mark recent additions from ASTERISK-11402 and ASTERISK-11679 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113752 By: Digium Subversion (svnbot) 2008-04-09 11:20:40 Repository: asterisk Revision: 113758 _U  branches/1.6.0/ ------------------------------------------------------------------------ r113758 | tilghman | 2008-04-09 11:20:36 -0500 (Wed, 09 Apr 2008) | 9 lines Blocked revisions 113752 via svnmerge ........ r113752 | tilghman | 2008-04-09 11:23:30 -0500 (Wed, 09 Apr 2008) | 2 lines Mark recent additions from ASTERISK-11402 and ASTERISK-11679 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113758